Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Refactor histogram to separate logic for multi- and single-channel images #2786

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

maaleske
Copy link
Contributor

@maaleske maaleske commented Sep 1, 2017

Description

In preparation for future histogram options for multichannel images, this PR separates the single-channel histogram calculation to an internal function, with any channel-number dependent branching (currently only the warning) in the exposed function.

Checklist

References

For reviewers

(Don't remove the checklist below.)

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.

@codecov-io
Copy link

codecov-io commented Sep 1, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@a665476). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2786   +/-   ##
=========================================
  Coverage          ?   85.42%           
=========================================
  Files             ?      330           
  Lines             ?    26483           
  Branches          ?        0           
=========================================
  Hits              ?    22624           
  Misses            ?     3859           
  Partials          ?        0
Impacted Files Coverage Δ
skimage/exposure/exposure.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a665476...6b1393a. Read the comment docs.

Base automatically changed from master to main February 18, 2021 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants