Color spaces C1C2C3 and MAXRGB added. #2915

imransalam · 2017-12-08T11:45:33Z

Description

This is an addition to color spaces, I have added two color spaces, i-e C1C2C3 and MAXRGB.

Checklist

[It's fine to submit PRs which are a work in progress! But before they are merged, all PRs should provide:]

[ Yes ] Clean style in the spirit of PEP8
[ Yes ] Docstrings for all functions
[ Could Not find any examples of color conversions in ./doc/examples] Gallery example in ./doc/examples (new features only)
[ Yes ] Unit tests

[For detailed information on these and other aspects see scikit-image contribution guidelines]

References

https://arxiv.org/abs/1702.05421
https://docs.gimp.org/en/plug-in-max-rgb.html

For reviewers

(Don't remove the checklist below.)

Check that the PR title is short, concise, and will make sense 1 year
later.
Check that new functions are imported in corresponding __init__.py.
Check that new features, API changes, and deprecations are mentioned in
doc/release/release_dev.rst.

pep8speaks · 2017-12-08T11:45:36Z

Hello @imransalam! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-12-06 11:44:21 UTC

imransalam · 2017-12-08T12:04:53Z

@pep8speaks Hi, I've updated the skimage/color/colorconv.py with PEP8 standards in the latest commit.

codecov-io · 2017-12-08T12:16:36Z

Codecov Report

Merging #2915 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2915      +/-   ##
==========================================
+ Coverage   86.04%   86.04%   +<.01%     
==========================================
  Files         337      337              
  Lines       27032    27046      +14     
==========================================
+ Hits        23259    23272      +13     
- Misses       3773     3774       +1

Impacted Files	Coverage Δ
skimage/color/__init__.py	`100% <ø> (ø)`	⬆️
skimage/color/colorconv.py	`99.11% <100%> (+0.03%)`	⬆️
skimage/draw/_random_shapes.py	`95.06% <0%> (-1.24%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2a6094...c19ddd2. Read the comment docs.

hmaarrfk · 2019-07-06T16:29:04Z

This looks really cool.

Sorry that this slipped the radar. Are you still interested in adding this? It would definitely need some tests that ensure:

The mathematical correctness.
The range of inputs (Grayscale vs RGB) we care for are adequately addressed.

imransalam · 2019-07-06T17:07:11Z

@hmaarrfk Hey. Sure let me know what tests you want to perform.

hmaarrfk · 2019-07-06T17:14:18Z

Cool, take a look at
https://github.com/scikit-image/scikit-image/blob/master/skimage/color/tests/test_colorconv.py#L497

essentially, you will want to add your function, each prefixed with test.

Probably in that same directory.

Don't worry about putting them in a class that is some old stuff that was required by nose.

Generally, you might want to find an other way to compute the result. That could be:

finding a less efficient way of computing it.
Copy pasting the output of a manually checked result.

See what you can think of on the test side.

hmaarrfk · 2019-07-06T17:15:11Z

skimage/color/colorconv.py

@@ -41,7 +41,7 @@
 :author: Travis Oliphant (XYZ and RGB CIE functions)
 :author: Matt Terry (lab2lch)
 :author: Alex Izvorski (yuv2rgb, rgb2yuv and related)
-


I think generally we are now adding each person's contributions to the file CONTRIBUTORS.txt.

@stefanv should Imram add his name here too for this module?

hmaarrfk · 2019-07-06T17:18:12Z

skimage/color/colorconv.py

+
+    References
+    ----------
+    .. [1] https://arxiv.org/abs/1702.05421


This reference needs to be fleshed out some more. I wish we could convert bib files to our format easily.

hmaarrfk · 2019-07-06T17:18:31Z

skimage/color/colorconv.py

+    --------
+    >>> from skimage import data
+    >>> img = data.astronaut()
+    >>> img_c1c2c3 = rgb2c1c2c3(img)


This example is probably better shown in a gallery.

hmaarrfk · 2019-07-06T17:18:56Z

skimage/color/colorconv.py

+
+    References
+    ----------
+    .. [1] https://docs.gimp.org/en/plug-in-max-rgb.html


This should at least be given a title and a retrieved on time stamp.

hmaarrfk · 2019-07-06T17:20:55Z

skimage/color/colorconv.py

+
+    Examples
+    --------
+    >>> from skimage import data


See if you can adapt your code to fit in a new file in this directory.

https://github.com/scikit-image/scikit-image/tree/master/doc/examples/color_exposure

hmaarrfk · 2019-07-06T17:23:03Z

@imransalam before working on anything, I would see if anybody else from @scikit-image/core has objection to adding this kind of functionality. Color space has been quite contentious here as the API has been inconsistent and some have even proposed moving to an other library. I cant see to recall the exact conversation though.

Borda · 2019-07-13T08:43:55Z

skimage/color/colorconv.py

@@ -679,6 +679,85 @@ def rgb2xyz(rgb):
    return _convert(xyz_from_rgb, arr)


+
+def rgb2c1c2c3(rgb):
+    """RGB to C1C2C3 color space conversion.


I would welcome a short decribtion of what the C1C2C3 is... giving reference is nice but keep it easy to use :)

Borda · 2019-07-13T08:48:38Z

skimage/color/colorconv.py

+    >>> img_c1c2c3 = rgb2c1c2c3(img)
+    """
+    out = np.arctan(rgb / np.dstack((
+        np.maximum(rgb[..., 1], rgb[..., 2]) + 0.000000001, 


rather use np.finfo(float).eps
https://het.as.utexas.edu/HET/Software/Numpy/reference/generated/numpy.finfo.html

Borda · 2019-07-13T08:49:27Z

skimage/color/colorconv.py

+
+
+def rgb2maxrgb(rgb):
+    """RGB to MAXRGB color space conversion.


I would welcome a short description of what the MAXRGB is... giving reference is nice but keep it easy to use :)

Borda · 2019-07-13T08:52:49Z

skimage/color/colorconv.py

+    R = rgb[:, :, 0]
+    G = rgb[:, :, 1]
+    B = rgb[:, :, 2]
+    M = np.maximum( np.maximum(R, G), B)


np.max(rgb, axis=-1) is easier to read/undestand

Updated the description for C1C2C3 and MaxRGB. Added np.finfo(float).eps instead of adding a small floating point myself. Used the max with axis=-1.

Added test cases for both maxrgb and c1c2c3. Manual testing.

imransalam added 4 commits December 8, 2017 15:52

rgb2c1c2c3 and rgb2maxrgb added in color convertions

c47d163

__init__.py updated

8381206

Smoothing Factor added in rgb2c1c2c3

d232143

Deep copying issue in max rgb resolved

579bca8

imransalam closed this Dec 8, 2017

imransalam reopened this Dec 8, 2017

Changes made wrt to PEP8 Standards

c19ddd2

imransalam closed this Dec 8, 2017

imransalam reopened this Dec 8, 2017

soupault added 🧐 Needs review type: new feature labels Dec 8, 2017

soupault added this to the 0.15 milestone Dec 8, 2017

soupault modified the milestones: 0.15, 0.16 Apr 20, 2019

hmaarrfk reviewed Jul 6, 2019

View reviewed changes

Borda suggested changes Jul 13, 2019

View reviewed changes

imransalam added 3 commits July 14, 2019 17:06

Updated Description, suggested code changes

575b44c

Updated the description for C1C2C3 and MaxRGB. Added np.finfo(float).eps instead of adding a small floating point myself. Used the max with axis=-1.

Added test cases for maxrgb and c1c2c3

ddfc6ca

Added test cases for both maxrgb and c1c2c3. Manual testing.

resolving pep8 issues

6d563a7

imransalam added 3 commits July 14, 2019 18:45

solved pep8 issues

724dbd5

solved pep8 issues

47cccff

Merge branch 'master' into master

9c54bee

Base automatically changed from master to main February 18, 2021 18:22

mkcor mentioned this pull request Feb 22, 2021

2021's calendar of community management #5169

Closed

grlee77 added 🙏 Feature request and removed type: new feature labels Feb 22, 2022

mkcor mentioned this pull request Feb 28, 2022

2022's calendar of community management #6165

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Color spaces C1C2C3 and MAXRGB added. #2915

Color spaces C1C2C3 and MAXRGB added. #2915

imransalam commented Dec 8, 2017

pep8speaks commented Dec 8, 2017 •

edited

imransalam commented Dec 8, 2017

codecov-io commented Dec 8, 2017 •

edited

hmaarrfk commented Jul 6, 2019

imransalam commented Jul 6, 2019

hmaarrfk commented Jul 6, 2019

hmaarrfk Jul 6, 2019

hmaarrfk Jul 6, 2019

hmaarrfk Jul 6, 2019

hmaarrfk Jul 6, 2019

hmaarrfk Jul 6, 2019

hmaarrfk commented Jul 6, 2019

Borda Jul 13, 2019

Borda Jul 13, 2019

Borda Jul 13, 2019

Borda Jul 13, 2019



		def rgb2maxrgb(rgb):
		"""RGB to MAXRGB color space conversion.

Color spaces C1C2C3 and MAXRGB added. #2915

Are you sure you want to change the base?

Color spaces C1C2C3 and MAXRGB added. #2915

Conversation

imransalam commented Dec 8, 2017

Description

Checklist

References

For reviewers

pep8speaks commented Dec 8, 2017 • edited

Comment last updated at 2019-12-06 11:44:21 UTC

imransalam commented Dec 8, 2017

codecov-io commented Dec 8, 2017 • edited

Codecov Report

hmaarrfk commented Jul 6, 2019

imransalam commented Jul 6, 2019

hmaarrfk commented Jul 6, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hmaarrfk commented Jul 6, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pep8speaks commented Dec 8, 2017 •

edited

codecov-io commented Dec 8, 2017 •

edited