Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

During color conversion, maintain float precision #3060

Conversation

hmaarrfk
Copy link
Member

@hmaarrfk hmaarrfk commented May 7, 2018

Description

Color conversion currently imposes 64 bit types. I don't think this should be the case. Many images are taken with 8bit sensors and as such 32 bit floating point types are probably adequate.

I would rather actually fix this in img_as_float itself. See the PR #3062.

Checklist

[It's fine to submit PRs which are a work in progress! But before they are merged, all PRs should provide:]

[For detailed information on these and other aspects see scikit-image contribution guidelines]

References

[If this is a bug-fix or enhancement, it closes issue # ]
[If this is a new feature, it implements the following paper: ]

For reviewers

(Don't remove the checklist below.)

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.

@hmaarrfk hmaarrfk force-pushed the bugfix_do_not_impose_float64_in_color_conversion branch from 0fe02c3 to 01989b9 Compare May 19, 2018 00:41
@codecov-io
Copy link

codecov-io commented May 19, 2018

Codecov Report

Merging #3060 into master will decrease coverage by <.01%.
The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3060      +/-   ##
=========================================
- Coverage    85.9%   85.9%   -0.01%     
=========================================
  Files         336     336              
  Lines       27301   27312      +11     
=========================================
+ Hits        23454   23463       +9     
- Misses       3847    3849       +2
Impacted Files Coverage Δ
skimage/util/tests/test_dtype.py 100% <100%> (ø) ⬆️
skimage/color/colorconv.py 98.55% <88.88%> (-0.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10b0543...01989b9. Read the comment docs.

@emmanuelle emmanuelle closed this Jun 1, 2018
@hmaarrfk hmaarrfk deleted the bugfix_do_not_impose_float64_in_color_conversion branch November 4, 2018 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants