Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3141: Add bins argument to hough_line() #3318

Closed
wants to merge 2 commits into from

Conversation

abarya
Copy link
Contributor

@abarya abarya commented Aug 4, 2018

Description

With the argument bins, the user can now specify distances at which he/she is interested in computing the transform.

Fixes #3141

Checklist

[It's fine to submit PRs which are a work in progress! But before they are merged, all PRs should provide:]

[For detailed information on these and other aspects see scikit-image contribution guidelines]

References

[If this is a bug-fix or enhancement, it closes issue # ]
[If this is a new feature, it implements the following paper: ]

For reviewers

(Don't remove the checklist below.)

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.
  • Consider backporting the PR with @meeseeksdev backport to v0.14.x

@pep8speaks
Copy link

pep8speaks commented Aug 4, 2018

Hello @abhishekarya286! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on August 04, 2018 at 12:15 Hours UTC

@abarya
Copy link
Contributor Author

abarya commented Aug 4, 2018

Hi @stefanv @jni. Please review.

@soupault soupault added this to the 0.15 milestone Aug 4, 2018
@abarya
Copy link
Contributor Author

abarya commented Aug 18, 2018

Hi @jni. Any updates on this?

@emmanuelle
Copy link
Member

@abhishekarya286 you should add new tests in order to test for number of bins different than the current default (for example, oversampling and undersampling).

@soupault soupault modified the milestones: 0.15, 0.16 Apr 20, 2019
@sciunto sciunto modified the milestones: 0.16, 0.17 Jul 17, 2019
Base automatically changed from master to main February 18, 2021 18:23
@abarya abarya closed this Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hough line transform: allow setting distance resolution
5 participants