Test coverage #351
Merged
Test coverage #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -98,7 +98,7 @@ def find_contours(array, level, | |||
| """ | |||
| array = np.asarray(array, dtype=np.double) | |||
| if array.ndim != 2: | |||
| raise RuntimeError('Only 2D arrays are supported.') | |||
| raise TypeError('Only 2D arrays are supported.') | |||
|
Thanks! |
|
|
||
| ## def func(Y): | ||
| ## return ssim(X, Y, dynamic_range=255) | ||
| def test_ssim_grad(): |
There was a problem hiding this comment.
Could you add a note that this test is known to fail on OSX 10.6?
See the following thread for more information:
https://groups.google.com/d/topic/scikit-image/hOJhyDRzOG4/discussion
I never tracked down the source of the error, but @stefanv was able to reproduce the failure on a similar system so I don't think it's just me.
|
+1 |
|
Hmm, the tests ran fine on my system, but the Travis CI fails: I didn't notice until now that Travis isn't testing PRs anymore. |
|
I re-enabled it this morning, after the repo move. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements for test coverage of several functions / packages.
At the same time I fixed some bugs I came across.