Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Followup deprecations for 0.16 #3851

Merged
merged 7 commits into from May 19, 2019
Merged

Conversation

soupault
Copy link
Member

Description

Closes #3840 .

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.
  • Consider backporting the PR with @meeseeksdev backport to v0.14.x

@soupault soupault added 🔧 type: Maintenance Refactoring and maintenance of internals 🧐 Needs review labels Apr 19, 2019
@soupault soupault added this to the 0.16 milestone Apr 19, 2019
@pep8speaks
Copy link

pep8speaks commented Apr 19, 2019

Hello @soupault! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 387:11: E201 whitespace after '['
Line 387:25: E241 multiple spaces after ','
Line 388:11: E201 whitespace after '['
Line 389:11: E201 whitespace after '['

Comment last updated at 2019-04-23 07:49:01 UTC

@soupault soupault force-pushed the depr_016_followup branch 2 times, most recently from 69ef670 to 2cbda13 Compare April 20, 2019 10:13
@soupault
Copy link
Member Author

Ready for review.

Copy link
Member

@emmanuelle emmanuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a lot of work, thank you! I was just surprised that you made a change scheduled for 0.17. Also, there is a conflict with one file, could you please fix it?

@@ -27,8 +20,6 @@ Other
-----
* Remove legacy pretty printing workaround for ``pytest`` in ``conftest.py``
once minimal required ``numpy`` is set to >= 1.14.0.
* Remove deprecated ``Hxx, Hxy, Hyy`` API of ``hessian_matrix_eigvals`` in
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was planned for 0.17 so why do it now?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think maybe it was a misclassification in the TODO list.

The warning states 0.16
https://github.com/scikit-image/scikit-image/pull/3851/files#diff-70ef54b6b626ce40eefa32dae16fc130L338

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emmanuelle actually, it was in Other section.

Originally, the warning was introduced here -ef07903 (#2854), before 0.14.0. It looks like there is no mistake, and the change was correctly scheduled for 0.16.0 (2 major releases: deprecation in 0.15, removal in 0.16).

@stefanv
Copy link
Member

stefanv commented Apr 23, 2019

Thank you for working through this, Egor.

@sciunto
Copy link
Member

sciunto commented May 19, 2019

Great job! all looks good to me.

@sciunto sciunto merged commit 176548b into scikit-image:master May 19, 2019
@soupault soupault deleted the depr_016_followup branch May 19, 2019 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧐 Needs review 🔧 type: Maintenance Refactoring and maintenance of internals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle 0.16 deprecations
6 participants