New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Followup deprecations for 0.16 #3851
Conversation
Hello @soupault! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2019-04-23 07:49:01 UTC |
69ef670
to
2cbda13
Compare
Ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a lot of work, thank you! I was just surprised that you made a change scheduled for 0.17. Also, there is a conflict with one file, could you please fix it?
@@ -27,8 +20,6 @@ Other | |||
----- | |||
* Remove legacy pretty printing workaround for ``pytest`` in ``conftest.py`` | |||
once minimal required ``numpy`` is set to >= 1.14.0. | |||
* Remove deprecated ``Hxx, Hxy, Hyy`` API of ``hessian_matrix_eigvals`` in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was planned for 0.17 so why do it now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think maybe it was a misclassification in the TODO list.
The warning states 0.16
https://github.com/scikit-image/scikit-image/pull/3851/files#diff-70ef54b6b626ce40eefa32dae16fc130L338
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@emmanuelle actually, it was in Other
section.
Originally, the warning was introduced here -ef07903 (#2854), before 0.14.0. It looks like there is no mistake, and the change was correctly scheduled for 0.16.0 (2 major releases: deprecation in 0.15, removal in 0.16).
Thank you for working through this, Egor. |
20fb248
to
f29a48c
Compare
Great job! all looks good to me. |
Description
Closes #3840 .
For reviewers
later.
__init__.py
.doc/release/release_dev.rst
.@meeseeksdev backport to v0.14.x