-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alpha root filtering: new feature suggestion. #3982
base: main
Are you sure you want to change the base?
Conversation
Hello @iliailmer! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2022-03-22 14:44:45 UTC |
fork update
This reverts commit 721d510. reverting back
Hi @iliailmer thank you for contributing high-quality code, and sorry for the time it took to start reviewing (don't hesitate to ping devs another time :-)). I'm a bit hesitant here because the alpha-root filtering papers do not have a lot of citations. Could you please explain the advantage of the method compared to existing skimage filters (gaussian blurring, |
Hi @emmanuelle , thank you for the response. I think the algorithm has additional benefits: it can bring out details in greyscale images, for instance when I run it on cameraman from |
Description
I would like to add a new feature: root filtering. The basic idea is to use the fast Fourier transform on the input image and then raise the magnitude of the result to the power of$alpha$ ($alpha$ -root) which is a user-specified parameter. Then, the magnitude of the inverse transform is returned by the function.
The papers utilizing the feature are here, here, and here.
I listed the main reference in the description of the function:
A. K. Jain, Fundamentals of Digital Image Processing. Upper SaddleRiver, NJ: Prentice-Hall, 1989.
Checklist
./doc/examples
(new features only)./benchmarks
, if your changes aren't covered by anexisting benchmark
For reviewers
later.
__init__.py
.doc/release/release_dev.rst
.@meeseeksdev backport to v0.14.x