matplotlib: remove interpolation=nearest, none in our examples #4002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sciunto
added
the
📄 type: Documentation
|
Does this still output warnings? |
|
Warnings about what? I'm confused... |
|
I think this was added because we changed what interpolation method we used by default. If a user runs this with 0.16.dev, will they get many deprecation warnings? |
|
I'm still confused. Let me explain and see if it helps. Here we are talking about matplotlib. We have not decided which method to use by default (but mpl dev did). The removal of these options has no impact for users as mpl use nearest by default since a long time. they changed to this default value when they figured out that interpolating is not a good idea by default for people playing with images. |
hmaarrfk
approved these changes
Jul 10, 2019
|
.... good double explaining something that never needed it in the first place. Thanks for your patience! |
jni
approved these changes
Jul 10, 2019
clementkng
pushed a commit
to clementkng/scikit-image
that referenced
this pull request
Jul 12, 2019
…t-image#4002) * mpl use interpolation=nearest by default. Remove this option for the sake of clarity * replace interpolation=none by nearest (default) in gallery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #3998
Checklist
./doc/examples(new features only)./benchmarks, if your changes aren't covered by anexisting benchmark
For reviewers
later.
__init__.py.doc/release/release_dev.rst.@meeseeksdev backport to v0.14.x