Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #4236 on branch v0.16.x (Migrate to networkx 2.x) #4237

Merged

Conversation

meeseeksmachine
Copy link

Backport PR #4236: Migrate to networkx 2.x

@pep8speaks
Copy link

Hello @meeseeksmachine! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 58:71: W504 line break after binary operator

Line 213:64: W504 line break after binary operator
Line 369:71: W504 line break after binary operator
Line 551:15: E127 continuation line over-indented for visual indent

Line 126:71: W504 line break after binary operator

@NelleV
Copy link
Member

NelleV commented Oct 14, 2019

I'd like to postpone this backport a bit so that I can finish the release cleanly.

@jni
Copy link
Member

jni commented Oct 14, 2019

@NelleV no problem at all, merge this at your leisure! Or just let us know. =)

@jni
Copy link
Member

jni commented Oct 14, 2019

Anyway is there any issue at all with merging to the branch now that the tag is done?

@NelleV
Copy link
Member

NelleV commented Oct 14, 2019

We're good to go (I'm a bit surprised that you would backport such significant changes).

@jni jni merged commit 3cab945 into scikit-image:v0.16.x Oct 14, 2019
@jni
Copy link
Member

jni commented Oct 14, 2019

Well, as @jarrodmillman said, if someone installs scikit-image 0.16.1 and NetworkX 2.4 together, it will break. I consider that a big problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants