Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix label2rgb #4661

Merged
merged 6 commits into from May 8, 2020
Merged

Fix label2rgb #4661

merged 6 commits into from May 8, 2020

Conversation

emmanuelle
Copy link
Member

Closes #4657

@emmanuelle
Copy link
Member Author

please do not merge as I need to add tests and also it seems that the problem is not completely solved

@pep8speaks
Copy link

pep8speaks commented May 8, 2020 •
edited

Hello @emmanuelle! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-05-08 09:58:38 UTC

@emmanuelle
Copy link
Member Author

ok this is now ready for review :-)

emmanuelle
emmanuelle commented May 8, 2020
View reviewed changes
skimage/color/tests/test_colorlabel.py
@@ -38,6 +38,17 @@ def test_wrong_kind():
label2rgb(label, kind='foo', bg_label=-1)


def test_uint_image():
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this test is failing on master, img was not rescaled with img_as_float and therefore kept a 0-255 range while the color mask to be added was in the [0-1] range so not visible when superimposed. The output was float but in [0-255] so also matplotlib would represent it completely white in the gallery examples.

@jni jni merged commit d38c988 into scikit-image:master May 8, 2020
@emmanuelle emmanuelle mentioned this pull request May 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jni jni jni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bugs in label2rgb
3 participants
@emmanuelle @pep8speaks @jni