Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] MNT: Use an image fetcher class instead of global variables. #4704

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hmaarrfk
Copy link
Member

Description

@rfezzani this is the idea of using a class I had to avoid the generous use of globals out of order.

Honestly, at this stage, it doesn't fix any of the issues that are brought up, but I feel like it is a better starting point.

Feel free to take it over.

Checklist

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.

@pep8speaks
Copy link

Hello @hmaarrfk! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 119:80: E501 line too long (80 > 79 characters)
Line 124:80: E501 line too long (83 > 79 characters)
Line 128:80: E501 line too long (81 > 79 characters)
Line 146:80: E501 line too long (81 > 79 characters)
Line 201:80: E501 line too long (82 > 79 characters)
Line 227:80: E501 line too long (80 > 79 characters)
Line 243:1: E305 expected 2 blank lines after class or function definition, found 1

@rfezzani
Copy link
Member

That's even better @hmaarrfk 👏. I would also through this class definition out from the __init__.py file to keep it as short/clean as possible ;)
I'll try to find some time to work on this ASAP =)

@alexdesiqueira alexdesiqueira added the 🔧 type: Maintenance Refactoring and maintenance of internals label May 14, 2020
Base automatically changed from master to main February 18, 2021 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔧 type: Maintenance Refactoring and maintenance of internals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants