-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Use nep29 to help with the Python 3.6 -> 3.9 transition #5057
Conversation
Nice, thanks @hmaarrfk! Please let me know if there is anything you'd like to discuss here. It looks to me like Py3.9 will need to be side-loaded rather than using the CI service VMs? |
As of a week or two ago, both Appveyor and Travis have Python 3.9 available directly. For Appveyor, you might have to select the "Visual Studio 2019" image (https://www.appveyor.com/updates/2020/10/26/) |
It seems osx is timing out. Time to move to azure.???? |
Given that Travis recently announced that OSX builds on Travis are no longer going to be free, it doesn't seem that we will be able to keep them as is in any case. There are also new restrictions to 1000 minutes on Linux builds for free accounts. I don't know what our monthly usage is now, but I don't think 1000 minutes gets us very far. I think SciPy is planning to switch existing Travis linux builds to GitHub Actions. |
@jni I hope you aren't waiting on this PR to release the next version. This infrastructure stuff just likes to grow in scope. |
It seems builds are failing due to missing optional dependencies for python 3.9. i suggest skipping them for now. I'll try to work on that later. I think we have all the environment variables in place for that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor suggestion on changing the note. Other than that, I am +1 on merging this PR and moving to the next step.
Travis is failing on few builds. Probably related:
# (in `test_thresholding`)
> pytest.importorskip('dask', reason="dask python library is not installed")
E TypeError: importorskip() got an unexpected keyword argument 'reason'
Co-authored-by: Egor Panfilov <egor.v.panfilov@gmail.com>
This has become outdated (no Travis CI anymore, already dropped Python 3.6 and added 3.9). There are a handful of requirement .txt file increments ( |
Description
Migrates builds from python 3.6 to python 3.9 using nep29 to bump minimum version requirements.
Checklist
./doc/examples
(new features only)./benchmarks
, if your changes aren't covered by anexisting benchmark
For reviewers
later.
__init__.py
.doc/release/release_dev.rst
.