Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add builds for aarch64 #5098

Closed
wants to merge 1 commit into from
Closed

Conversation

hmaarrfk
Copy link
Member

@hmaarrfk hmaarrfk commented Dec 4, 2020

Description

Updating builds for aarch64: scikit-image/scikit-image-wheels#47

Checklist

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.

@grlee77
Copy link
Contributor

grlee77 commented Dec 4, 2020

I cancelled the Travis job for now. Can you disable Travis temporarily in this PR while testing other things? I thought we needed Travis for the AArch64 builds, but all the ones in the job I just canceled were AMD64.

@hmaarrfk
Copy link
Member Author

hmaarrfk commented Dec 4, 2020

I'm not too sure how ghactions works. I just figured i would try to follow a pattern.

@jni where did you see the artifact outputs.

Am i expecting artifacts from this build?

@jni
Copy link
Member

jni commented Dec 5, 2020

@hmaarrfk the wheel building actions are triggered on:

on:
  push:
    branches:
      - master
      - v[0-9]+.[0-9]+.x
      - cibuildwheel
    tags:
      - v*

and not on PRs. So, you should make PRs that change the wheel building to by creating a cibuildwheel branch. I just did this with your branch. Build happening here.

There is a lot of contributing documentation to be updated about all this. We haven't done it yet because we've done all this in quite a rush...

@jni
Copy link
Member

jni commented Dec 5, 2020

Hmm, @hmaarrfk what is the aarch suffix? Are the aarch wheels here? Or is there an upload missing maybe?

Screen Shot 2020-12-05 at 5 41 48 pm

@grlee77
Copy link
Contributor

grlee77 commented Dec 5, 2020

The wheels should end with a name like: manylinux2014_aarch64.whl
For example, the following were created by merging scikit-image/scikit-image-wheels#47: https://anaconda.org/scipy-wheels-nightly/scikit-image/files

I don't think it is possible to build the wheels for ARM via GitHub Actions (although perhaps it is possible via qemu emulation or something like that). We can do ARM builds on Travis at scikit-image-wheels, but now our credits have expired again. We can either request more credits again or build them after we get 10,000 credits again at the end of the month. Now that Travis is disabled on the main repo we shouldn't run out too fast.

We can potentially move these Travis-based ARM builds to this repo and use cibuildwheel for those as well if we want to keep all wheel builds in one place.

@jni
Copy link
Member

jni commented Dec 5, 2020

We can potentially move these Travis-based ARM builds to this repo and use cibuildwheel for those as well if we want to keep all wheel builds in one place.

I think this is a good choice. I also wonder whether qemu might keep things simpler (all wheels upload to one place). Medium term I'd like our tags to directly push the wheels to PyPI, as we do in napari.

@janaknat
Copy link
Contributor

@hmaarrfk @jni I've got a PR(#5197) to use Github Actions and cibuildwheel to build the aarch64 wheels. cibuildwheel support non-native architecture builds from v1.8.0 onwards. See https://cibuildwheel.readthedocs.io/en/stable/options/#archs for more information.

Base automatically changed from master to main February 18, 2021 18:23
@grlee77 grlee77 added the 🤖 type: Infrastructure CI, packaging, tools and automation label Aug 21, 2021
@grlee77
Copy link
Contributor

grlee77 commented Aug 21, 2021

closing as outdated (#5197 add aarch64 wheels)

@grlee77 grlee77 closed this Aug 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 type: Infrastructure CI, packaging, tools and automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants