-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add builds for aarch64 #5098
Add builds for aarch64 #5098
Conversation
I cancelled the Travis job for now. Can you disable Travis temporarily in this PR while testing other things? I thought we needed Travis for the AArch64 builds, but all the ones in the job I just canceled were AMD64. |
I'm not too sure how ghactions works. I just figured i would try to follow a pattern. @jni where did you see the artifact outputs. Am i expecting artifacts from this build? |
@hmaarrfk the wheel building actions are triggered on: on:
push:
branches:
- master
- v[0-9]+.[0-9]+.x
- cibuildwheel
tags:
- v* and not on PRs. So, you should make PRs that change the wheel building to by creating a There is a lot of contributing documentation to be updated about all this. We haven't done it yet because we've done all this in quite a rush... |
Hmm, @hmaarrfk what is the aarch suffix? Are the aarch wheels here? Or is there an upload missing maybe? |
The wheels should end with a name like: I don't think it is possible to build the wheels for ARM via GitHub Actions (although perhaps it is possible via qemu emulation or something like that). We can do ARM builds on Travis at We can potentially move these Travis-based ARM builds to this repo and use cibuildwheel for those as well if we want to keep all wheel builds in one place. |
I think this is a good choice. I also wonder whether qemu might keep things simpler (all wheels upload to one place). Medium term I'd like our tags to directly push the wheels to PyPI, as we do in napari. |
@hmaarrfk @jni I've got a PR(#5197) to use Github Actions and cibuildwheel to build the aarch64 wheels. cibuildwheel support non-native architecture builds from v1.8.0 onwards. See https://cibuildwheel.readthedocs.io/en/stable/options/#archs for more information. |
closing as outdated (#5197 add aarch64 wheels) |
Description
Updating builds for aarch64: scikit-image/scikit-image-wheels#47
Checklist
./doc/examples
(new features only)./benchmarks
, if your changes aren't covered by anexisting benchmark
For reviewers
later.
__init__.py
.doc/release/release_dev.rst
.