Single out docs-only PRs in review process.

[mkcor]

Description

@grlee77 updating the guidelines as per #5120 (comment).

Checklist

• Docstrings for all functions
• Gallery example in ./doc/examples (new features only)
• Benchmark in ./benchmarks, if your changes aren't covered by an
  existing benchmark
• Unit tests
• Clean style in the spirit of PEP8

For reviewers

• Check that the PR title is short, concise, and will make sense 1 year
  later.
• Check that new functions are imported in corresponding __init__.py.
• Check that new features, API changes, and deprecations are mentioned in
  doc/release/release_dev.rst.

[emmanuelle]

Thanks @mkcor! I'm wondering whether to merge your PR as is, or to specify "non-controversial pull requests" (meaning that for a long doc PR with a lot of stuff, it is still better to have two reviews). Thoughts?

[mkcor]

Thanks @mkcor! I'm wondering whether to merge your PR as is, or to specify "non-controversial pull requests" (meaning that for a long doc PR with a lot of stuff, it is still better to have two reviews). Thoughts?

I agree with you, @emmanuelle... It might be better not to merge this PR at all then, and keep the guidelines valid in the general case. I think it's not great to use the term "non-controversial" in a short bullet-point list, because it is subject to judgement. On the contrary, "docs-only" is objective, but we do want two reviewers if the "docs-only" PR is long and/or complex, indeed... So I would suggest using our judgement just like we've done so far. Feel free to close!

[emmanuelle]

@mkcor not completely sure here, I think core devs are not always aware (or they forget) that they can merge small doc PRs they are happy with... Let's wait for others to chime in and in any case, thanks for bringing up this point.

[jni]

I'm happy to go one way or the other here...

[mkcor]

Sorry, this almost fell in the cracks! I have included @grlee77's suggestion, which seems consensual.

[grlee77]

The other case I would encourage merging fairly quickly after a single review are minor fixes needed to restore CI to a working state (e.g. #5315, #5319 for two recent examples)

[mkcor]

@grlee77 good point! Added this other case (96850b1). I really appreciate your foolproof radar! 😁

[grlee77]

Thanks for updating. This looks ready to me