Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update boundary mode in profile_line #5174

Merged
merged 6 commits into from
Jan 22, 2021

Conversation

grlee77
Copy link
Contributor

@grlee77 grlee77 commented Jan 5, 2021

Description

This PR resolves a TODO item related to switching the default profile_line boundary mode to 'reflect' for release 0.19. I also added a small change to fix the behavior for modes 'constant' and 'wrap' using their new implementations from SciPy 1.6 when available. This fixes, for example, the unexpected behavior raised at the top of gh-4279.

Checklist

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.

@grlee77 grlee77 added the 🔧 type: Maintenance Refactoring and maintenance of internals label Jan 5, 2021
@grlee77 grlee77 added this to the 0.19 milestone Jan 5, 2021
Copy link
Member

@jni jni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

skimage/_shared/utils.py Outdated Show resolved Hide resolved
Copy link
Member

@rfezzani rfezzani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @grlee77, it seems that we need a rebase before merging 😉

@pep8speaks
Copy link

pep8speaks commented Jan 22, 2021

Hello @grlee77! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-01-22 12:35:35 UTC

@rfezzani
Copy link
Member

Thank you @grlee77 🎉

@rfezzani rfezzani merged commit 8c9bd3b into scikit-image:master Jan 22, 2021
@grlee77 grlee77 deleted the profile_mode_update branch July 8, 2021 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔧 type: Maintenance Refactoring and maintenance of internals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants