FIX: handle 1D array in gaussian filter

[sciunto]

Description

See #5195

Checklist

• Docstrings for all functions
• Gallery example in ./doc/examples (new features only)
• Benchmark in ./benchmarks, if your changes aren't covered by an
  existing benchmark
• Unit tests
• Clean style in the spirit of PEP8

For reviewers

• Check that the PR title is short, concise, and will make sense 1 year
  later.
• Check that new functions are imported in corresponding __init__.py.
• Check that new features, API changes, and deprecations are mentioned in
  doc/release/release_dev.rst.

[rfezzani]

Thank you @sciunto, I think that the beginning of the gaussian function and may be the _guess_spatial_dimensions error message must be refactored. But I am not sure that an error have to be raised since it is filtered by a try ... Except ... block...

[sciunto]

Thank you @sciunto, I think that the beginning of the gaussian function and may be the _guess_spatial_dimensions error message must be refactored. But I am not sure that an error have to be raised since it is filtered by a try ... Except ... block...

I would even wonder whether keeping a guess is the right thing. I thought we want to avoid as much as possible magic. Other opinions @jni @emmanuelle ?

[pep8speaks]

Hello @sciunto! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file skimage/filters/_gaussian.py:

Line 159:80: E501 line too long (83 > 79 characters)

• In the file skimage/filters/tests/test_gaussian.py:

Line 20:1: W293 blank line contains whitespace

Comment last updated at 2021-02-01 10:51:32 UTC

[grlee77]

I would even wonder whether keeping a guess is the right thing. I thought we want to avoid as much as possible magic. Other opinions @jni @emmanuelle ?

We have mostly gotten rid of this type of guessing elsewhere (this function is one exception noted in the list at the top of #2613). It looks like @jni and I discussed it here: #2613 (comment) and decided to address it as part of #4294. Working on that issue is one of my near-term priorities for the CZI grant, so we should be able to make progress soon.

[grlee77]

I vote for merging this as-is and then deal with removing _guess_spatial_dimensions separately

[rfezzani]

Thank you @sciunto, waiting for the green button before merging 😉

[jni]

Failure is expected from #5211, so I'll merge now. Thanks everyone!

[stefanv]

Thanks for fixing this @sciunto!

The new docstring does not look right: ValueError "If the image array has less than four dimensions.".