Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

single precision support in skimage.restoration module #5219

Merged
merged 14 commits into from
May 21, 2021
Merged

single precision support in skimage.restoration module #5219

merged 14 commits into from
May 21, 2021

Commits on Apr 23, 2021

  1. ENH: add float32 support to wiener, unsupervised_wiener, rolling_ball

    @grlee77
    grlee77 committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    d8ab26a View commit details
    Browse the repository at this point in the history

  2. pep8 fixes

    @grlee77
    grlee77 committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    ff0ef76 View commit details
    Browse the repository at this point in the history

  3. incorporate reviewer feedback 

    _float_type -> _supported_float_type

test with additional dtypes (float16, float128)

suppress RuntimeWarnings in richardson_lucy
    @grlee77
    grlee77 committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    b4d905a View commit details
    Browse the repository at this point in the history

  4. float128 unavailable on some platforms

    @grlee77
    grlee77 committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    fb83eed View commit details
    Browse the repository at this point in the history

  5. remove additional float128 case

    @grlee77
    grlee77 committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    f1cb2d6 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2021

  1. fix conflicts 

    add dtype-dependent rtol to test_inpaint_biharmonic_2d
    @grlee77
    grlee77 committed May 12, 2021
    Configuration menu
    Copy the full SHA
    2391da5 View commit details
    Browse the repository at this point in the history

  2. apply style suggestion

    @grlee77
    grlee77 committed May 12, 2021
    Configuration menu
    Copy the full SHA
    9561041 View commit details
    Browse the repository at this point in the history

  3. fix _invariant_denoise for float16 inputs

    @grlee77
    grlee77 committed May 12, 2021
    Configuration menu
    Copy the full SHA
    cba69bb View commit details
    Browse the repository at this point in the history

  4. fix typo

    @grlee77
    grlee77 committed May 12, 2021
    Configuration menu
    Copy the full SHA
    b713a87 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2021

  1. Update test_denoise_nl_means_multichannel 

    - use a test image with more structure
- fix the random seed
- tune denoising parameters a bit

With this updates the difference between 3D vs 2D is more pronounced.

test float16 dtype
    @grlee77
    grlee77 committed May 13, 2021
    Configuration menu
    Copy the full SHA
    d32f073 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2021

  1. Apply suggestions from code review 

    Co-authored-by: Riadh Fezzani <rfezzani@gmail.com>
    @grlee77 @rfezzani
    grlee77 and rfezzani committed May 21, 2021
    Configuration menu
    Copy the full SHA
    bdb5adf View commit details
    Browse the repository at this point in the history

  2. prefer pytest.mark.parameterize

    @grlee77
    grlee77 committed May 21, 2021
    Configuration menu
    Copy the full SHA
    67efd1c View commit details
    Browse the repository at this point in the history

  3. prefer pytest.mark.parameterize

    @grlee77
    grlee77 committed May 21, 2021
    Configuration menu
    Copy the full SHA
    2eae9be View commit details
    Browse the repository at this point in the history

  4. Merge branch 'float32_restoration' of github.com:grlee77/scikit-image… 

    … into float32_restoration
    @grlee77
    grlee77 committed May 21, 2021
    Configuration menu
    Copy the full SHA
    a9e53ee View commit details
    Browse the repository at this point in the history