Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convex hull object implementation #522

Closed
wants to merge 12 commits into from

Conversation

chintak
Copy link
Contributor

@chintak chintak commented Apr 22, 2013

Included in convex_hull.py file as two additional functions.
connected_components(image, start_pixel_tuple): Computes the object connected to start_pixel_tuple and returns a bool array of same size as`image`` but with only that 1 segmented object.

convex_hull_object(image, output_form): Given a binary image, it computes the convex hull of the individual objects. For return, it can either return a 2D binary image with all the individual convex hulls or return a 3D array with segmented convex hull for each object.

@sciunto
Copy link
Member

sciunto commented Apr 22, 2013

travis indicates you still have some trouble with tabs.

"""Compute the convex hull image of a binary image.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whitespace noise shouldn't be in the PR. Configure your editor to change all tabs to spaces, to remove all trailing whitespace.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am outside right now, but I will sit and configure this once and for all. Sorry for this. Any suggestions on the preferable text editor to use on OS X ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sublime is hard to beat.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Josh,

Aah thanks for the suggestion. I'll try it out.

Chintak

@chintak
Copy link
Contributor Author

chintak commented Apr 23, 2013

Also I think I should probably close this PR. Send one, once I have a flood fill implementation at least for 3D. ;)
No point crowding this pace.

@chintak chintak closed this Apr 23, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants