Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove approximation in ransac circle model #5221

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sciunto
Copy link
Member

@sciunto sciunto commented Feb 5, 2021

Description

closes #5186

Checklist

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.

@pep8speaks
Copy link

Hello @sciunto! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 289:28: E226 missing whitespace around arithmetic operator
Line 289:40: E226 missing whitespace around arithmetic operator
Line 299:28: E226 missing whitespace around arithmetic operator
Line 299:40: E226 missing whitespace around arithmetic operator
Line 300:34: E226 missing whitespace around arithmetic operator
Line 301:34: E226 missing whitespace around arithmetic operator
Line 311:27: E226 missing whitespace around arithmetic operator
Line 311:42: E226 missing whitespace around arithmetic operator

Base automatically changed from master to main February 18, 2021 18:23
@grlee77 grlee77 added the ⏩ type: Enhancement Improve existing features label Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⏩ type: Enhancement Improve existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CircleModel does not minimize squared distances
3 participants