Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Laplacian matrix size bug in random_walker #5238

Merged
merged 1 commit into from
Feb 23, 2021

Conversation

grlee77
Copy link
Contributor

@grlee77 grlee77 commented Feb 15, 2021

Description

closes #5034 using the suggestion from @morgan-bc in that issue (thanks!). The max size as used here looks like the maximum possible value for the unlabeled_indices array that is used later in indexing the rows and columns.

Checklist

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.

@grlee77 grlee77 added the 🩹 type: Bug fix Fixes unexpected or incorrect behavior label Feb 15, 2021
Copy link
Member

@rfezzani rfezzani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @grlee77, perfect 😉

Base automatically changed from master to main February 18, 2021 18:23
@emmanuelle
Copy link
Member

CI failure does not seem related to this PR, merging. Thanks for the fix @grlee77 !

@emmanuelle emmanuelle merged commit be6e3dc into scikit-image:main Feb 23, 2021
@grlee77 grlee77 deleted the random_walker_fix branch July 8, 2021 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🩹 type: Bug fix Fixes unexpected or incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

random_walker segmentation can create incorrect laplacian matrix
3 participants