Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dim generalization #5251

Closed
wants to merge 9 commits into from
Closed

Conversation

ghost
Copy link

@ghost ghost commented Feb 25, 2021

Description

Checklist

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.

@pep8speaks
Copy link

Hello @am-block! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 4:10: E401 multiple imports on one line
Line 13:1: E302 expected 2 blank lines, found 1
Line 14:5: E265 block comment should start with '# '
Line 15:30: E262 inline comment should start with '# '
Line 18:17: E265 block comment should start with '# '
Line 19:41: E226 missing whitespace around arithmetic operator
Line 19:55: E226 missing whitespace around arithmetic operator
Line 20:46: E226 missing whitespace around arithmetic operator
Line 20:60: E226 missing whitespace around arithmetic operator
Line 21:60: W291 trailing whitespace
Line 22:41: E226 missing whitespace around arithmetic operator
Line 22:47: E226 missing whitespace around arithmetic operator
Line 22:54: E226 missing whitespace around arithmetic operator
Line 22:60: E226 missing whitespace around arithmetic operator
Line 22:70: E226 missing whitespace around arithmetic operator
Line 22:73: E226 missing whitespace around arithmetic operator
Line 22:80: E501 line too long (88 > 79 characters)
Line 22:83: E226 missing whitespace around arithmetic operator
Line 22:87: E226 missing whitespace around arithmetic operator
Line 25:1: E302 expected 2 blank lines, found 1
Line 26:5: E265 block comment should start with '# '
Line 26:80: E501 line too long (85 > 79 characters)
Line 27:5: E265 block comment should start with '# '
Line 29:39: E231 missing whitespace after ','
Line 29:46: E231 missing whitespace after ','
Line 30:5: E265 block comment should start with '# '
Line 31:5: E265 block comment should start with '# '
Line 35:1: E302 expected 2 blank lines, found 1
Line 42:1: E302 expected 2 blank lines, found 1
Line 43:5: E265 block comment should start with '# '
Line 45:5: E265 block comment should start with '# '
Line 49:4: E114 indentation is not a multiple of four (comment)
Line 49:80: E501 line too long (96 > 79 characters)
Line 50:5: E265 block comment should start with '# '
Line 58:1: E302 expected 2 blank lines, found 1
Line 59:5: E265 block comment should start with '# '
Line 61:80: E501 line too long (85 > 79 characters)
Line 61:86: W291 trailing whitespace
Line 62:9: E128 continuation line under-indented for visual indent
Line 64:77: W291 trailing whitespace
Line 65:9: E128 continuation line under-indented for visual indent
Line 67:80: E501 line too long (85 > 79 characters)
Line 67:86: W291 trailing whitespace
Line 68:9: E128 continuation line under-indented for visual indent
Line 71:33: E225 missing whitespace around operator
Line 71:45: E226 missing whitespace around arithmetic operator
Line 71:58: E226 missing whitespace around arithmetic operator
Line 72:1: W293 blank line contains whitespace
Line 73:1: W293 blank line contains whitespace
Line 74:5: E303 too many blank lines (2)
Line 76:1: E302 expected 2 blank lines, found 1
Line 77:5: E265 block comment should start with '# '
Line 79:44: E261 at least two spaces before inline comment
Line 79:45: E262 inline comment should start with '# '
Line 84:13: E722 do not use bare 'except'
Line 88:27: E231 missing whitespace after ','
Line 92:28: E261 at least two spaces before inline comment
Line 92:29: E262 inline comment should start with '# '
Line 97:1: E302 expected 2 blank lines, found 1
Line 98:24: E231 missing whitespace after ','
Line 99:32: E231 missing whitespace after ','
Line 100:32: E231 missing whitespace after ','
Line 101:17: E231 missing whitespace after ','
Line 103:1: E302 expected 2 blank lines, found 1
Line 104:5: E265 block comment should start with '# '
Line 106:5: E265 block comment should start with '# '
Line 109:14: E231 missing whitespace after ','
Line 109:18: E231 missing whitespace after ','
Line 109:62: E261 at least two spaces before inline comment
Line 109:62: E262 inline comment should start with '# '
Line 113:22: E231 missing whitespace after ','
Line 113:33: E231 missing whitespace after ','
Line 115:35: E231 missing whitespace after ','
Line 120:26: E261 at least two spaces before inline comment
Line 120:27: E262 inline comment should start with '# '
Line 121:9: E265 block comment should start with '# '
Line 121:80: E501 line too long (104 > 79 characters)
Line 127:1: E305 expected 2 blank lines after class or function definition, found 1
Line 128:5: E265 block comment should start with '# '
Line 130:5: E265 block comment should start with '# '
Line 131:5: E265 block comment should start with '# '
Line 132:50: E261 at least two spaces before inline comment
Line 132:51: E262 inline comment should start with '# '
Line 133:5: E265 block comment should start with '# '
Line 134:5: E265 block comment should start with '# '
Line 135:10: E231 missing whitespace after ','
Line 138:44: E231 missing whitespace after ','
Line 138:49: E231 missing whitespace after ','
Line 139:26: E231 missing whitespace after ','
Line 139:39: E231 missing whitespace after ','
Line 139:52: E231 missing whitespace after ','
Line 139:58: E231 missing whitespace after ','

Line 249:10: W291 trailing whitespace
Line 251:26: E231 missing whitespace after ','

@ghost ghost closed this Feb 25, 2021
@ghost ghost deleted the Dim_Generalization branch February 25, 2021 17:09
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants