Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix skimage.measure.label segfault #5264

Merged
merged 3 commits into from
Mar 11, 2021

Conversation

rfezzani
Copy link
Member

Description

Fixes #5260.

Checklist

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.

@rfezzani rfezzani added the 🩹 type: Bug fix Fixes unexpected or incorrect behavior label Mar 10, 2021
Copy link
Member

@jni jni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rfezzani! My initial instinct was to aim for putting the check in the Python function, but that still would leave us open to segfaults e.g. if someone internally used the Cython for some other reason. So, this is strictly better I reckon. 👍

@jni
Copy link
Member

jni commented Mar 11, 2021

The optional deps test failure is from a new dask release and not related to this PR.

@grlee77 grlee77 merged commit 944760c into scikit-image:main Mar 11, 2021
@grlee77
Copy link
Contributor

grlee77 commented Mar 11, 2021

Thanks for the quick fix, @rfezzani

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🩹 type: Bug fix Fixes unexpected or incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

label() segfault with arrays of shape (n,0,m) on linux + anaconda
3 participants