-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add data files for new illuminants. #5276
Conversation
Hello @mkcor! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
This reverts commit 173c356.
@hmaarrfk please review/approve ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that adding the files to the registry itself causes test to fail.
I noticed that the azure pipelines all build off the build wheels.
They will fail without a pull request like this.
I'm kinda ok with this, but I think that merging #5283 would have caused fewer failures. I can't really inspect the azure failures, but in either case, it is clear that the build system has stopped that PR from going through. I would be ok just merging the main PR as is. |
Yes, because the files don't live in |
Description
Following up with #5234 -- only adding the new data here.
Checklist
./doc/examples
(new features only)./benchmarks
, if your changes aren't covered by anexisting benchmark
For reviewers
later.
__init__.py
.doc/release/release_dev.rst
.