Stick with usual convention for 3D spatial coords #5282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 20, 2021
jni
reviewed
Mar 25, 2021
| @@ -53,7 +53,7 @@ | |||
| data[n_plane // 2, :, :, 1], | |||
| zmin=v_min, | |||
| zmax=v_max, | |||
| labels={'x': 'Y', 'y': 'X', 'color': 'intensity'} | |||
| labels={'x': 'row', 'y': 'col', 'color': 'intensity'} | |||
There was a problem hiding this comment.
Aww there we go!! It's because x=col and y=row that I loaded the dataset with the following dimension order: [z, y, x, c] = [plane, row, column, channel] 😌
Ok, so I'll revert 58eec1c (where I introduced the inversion) and proceed with the expected renaming 😅
jni
reviewed
Mar 25, 2021
Comment on lines
82
to
83
| # (n_Z, n_X, n_Y) = sample.shape | ||
| # Z, X, Y = np.mgrid[:n_Z, :n_X, :n_Y] |
There was a problem hiding this comment.
Right, reverted with 0da52ca.
jni
reviewed
Mar 25, 2021
| @@ -105,15 +105,16 @@ | |||
| sample[0, :, :], | |||
| zmin=v_min, | |||
| zmax=v_max, | |||
| labels={'x': 'Y', 'y': 'X', 'color': 'intensity'}, | |||
| labels={'x': 'row', 'y': 'col', 'color': 'intensity'}, | |||
|
@jni thanks for reviewing! |
jni
approved these changes
Mar 25, 2021
|
Thank you @mkcor! Since this is a doc fix I'm gonna go ahead and merge. If anyone finds further issues we can always update again. 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5275
Checklist
./doc/examples(new features only)./benchmarks, if your changes aren't covered by anexisting benchmark
For reviewers
later.
__init__.py.doc/release/release_dev.rst.