Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: use internal function for noise + clarify code in canny example #5293

Merged
merged 1 commit into from
Mar 24, 2021

Conversation

sciunto
Copy link
Member

@sciunto sciunto commented Mar 24, 2021

Description

I propose to update the canny example to make it more "modern": variable name, noise function...

Here is the new image
index

Checklist

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.

@sciunto sciunto added the 📄 type: Documentation Updates, fixes and additions to documentation label Mar 24, 2021
@sciunto sciunto changed the title MAINT: use internal function for noise + clarify code MAINT: use internal function for noise + clarify code in canny example Mar 24, 2021
Copy link
Member

@jni jni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great! 😊

@hmaarrfk hmaarrfk merged commit c903a8c into scikit-image:main Mar 24, 2021
@hmaarrfk
Copy link
Member

nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📄 type: Documentation Updates, fixes and additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants