Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace numpy dtype by builtin dtype #5316

Merged
merged 2 commits into from
Apr 6, 2021

Conversation

sciunto
Copy link
Member

@sciunto sciunto commented Apr 6, 2021

Description

Follows #5103

Checklist

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.

@grlee77
Copy link
Contributor

grlee77 commented Apr 6, 2021

I see an unrelated sphinx warning is causing some failures, but this fix looks good and uncontroversial so I will go ahead and merge to help get CI toward a working state again.

Warning, treated as error:
role 'arxiv' is already registered, it will be overridden
make[1]: *** [Makefile:58: html] Error 2
make[1]: Leaving directory '/home/runner/work/scikit-image/scikit-image/doc'

@grlee77 grlee77 merged commit 5ed9bd6 into scikit-image:main Apr 6, 2021
@hmaarrfk
Copy link
Member

hmaarrfk commented Apr 6, 2021

Should we backport this. Seems safe

@sciunto
Copy link
Member Author

sciunto commented Apr 7, 2021

I see an unrelated sphinx warning is causing some failures, but this fix looks good and uncontroversial so I will go ahead and merge to help get CI toward a working state again.

Warning, treated as error:
role 'arxiv' is already registered, it will be overridden
make[1]: *** [Makefile:58: html] Error 2
make[1]: Leaving directory '/home/runner/work/scikit-image/scikit-image/doc'

Oh, it's related to a feature I added. I guess it is implemented in sphinx now. I'll have a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants