Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sphinx layout to make the search engine working for latest sphinx versions #5320

Merged
merged 3 commits into from
Apr 26, 2021

Conversation

sciunto
Copy link
Member

@sciunto sciunto commented Apr 7, 2021

Description

closes #4647

Checklist

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.

@sciunto sciunto marked this pull request as draft April 7, 2021 08:36
@sciunto
Copy link
Member Author

sciunto commented Apr 7, 2021

It's searching forever, same behavior on artifact and locally...

@sciunto sciunto marked this pull request as ready for review April 8, 2021 16:19
@sciunto
Copy link
Member Author

sciunto commented Apr 8, 2021

@scikit-image/core I got some help from sphinx community and the search engine is working again (tested locally). Please check and review.

Example: https://1647-2014929-gh.circle-artifacts.com/0/doc/build/html/search.html?q=canny&check_keywords=yes&area=default

@sciunto sciunto added 📄 type: Documentation Updates, fixes and additions to documentation 🔧 type: Maintenance Refactoring and maintenance of internals labels Apr 8, 2021
@sciunto sciunto changed the title unblock recent sphinx versions Fix sphinx layout to make the search engine working for latest sphinx versions Apr 8, 2021
@sciunto sciunto requested a review from emmanuelle April 8, 2021 17:24
Copy link
Contributor

@grlee77 grlee77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @sciunto! It is working on the artifact for me as well

@alexdesiqueira alexdesiqueira merged commit 25f7039 into scikit-image:main Apr 26, 2021
@alexdesiqueira
Copy link
Member

Thank you @sciunto !

@sciunto sciunto deleted the upgradesphinx branch April 27, 2021 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📄 type: Documentation Updates, fixes and additions to documentation 🔧 type: Maintenance Refactoring and maintenance of internals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update blocked versions for sphinx in requirement.txt
3 participants