Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

single precision support in moments functions #5344

Merged
merged 8 commits into from Apr 23, 2021
Merged

single precision support in moments functions #5344

merged 8 commits into from Apr 23, 2021

Conversation

grlee77
Copy link
Contributor

@grlee77 grlee77 commented Apr 21, 2021

Description

closes #5199
This PR continues the work started in #5200.

The first commit here is a cherry-pick of the _supported_float_dtype function introduced in #5219. We can rebase here once that PR is merged.

Checklist

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.

@grlee77 grlee77 added ⏩ type: Enhancement Improve existing features 📜 type: API Involves API change(s) labels Apr 21, 2021
@grlee77 grlee77 added this to In progress in skimage2 API Apr 21, 2021
jni
jni approved these changes Apr 22, 2021
View reviewed changes
Copy link
Member

@jni jni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you @grlee77! I've suggested a couple of typo fixes, but this is otherwise fine by me. 👍

skimage/_shared/utils.py Outdated Show resolved Hide resolved
skimage/_shared/utils.py Outdated Show resolved Hide resolved
@grlee77 @jni
Apply suggestions from code review
c358794 
Co-authored-by: Juan Nunez-Iglesias <juan.nunez-iglesias@monash.edu>
@grlee77
Copy link
Contributor Author

grlee77 commented Apr 22, 2021

I don't think it matters if we merge this one or #5219 first. I will just rebase the other as needed

rfezzani
rfezzani reviewed Apr 22, 2021
View reviewed changes
Copy link
Member

@rfezzani rfezzani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @grlee77, I just left a suggestion, otherwise it looks good to me 😉

skimage/measure/tests/test_moments.py Show resolved Hide resolved
skimage/measure/_moments.py Outdated Show resolved Hide resolved
@grlee77
Copy link
Contributor Author

grlee77 commented Apr 22, 2021

@rfezzani, please merge if this looks good to you know

@jni
Copy link
Member

jni commented Apr 23, 2021

@grlee77 looks like the last change killed the CI...

@grlee77
Copy link
Contributor Author

grlee77 commented Apr 23, 2021

@grlee77 looks like the last change killed the CI...

right, it should be fixed now

@jni jni merged commit a191691 into scikit-image:main Apr 23, 2021
@rfezzani
Copy link
Member

🎉 sorry @grlee77 for being late 😕! Thank you again 😉

tupui pushed a commit to tupui/scikit-image that referenced this pull request Apr 27, 2021
@grlee77 @jni @tupui
single precision support in moments functions (scikit-image#5344)
5c285af 
Co-authored-by: Juan Nunez-Iglesias <juan.nunez-iglesias@monash.edu>
@grlee77 grlee77 moved this from In progress to Done in skimage2 API Jun 21, 2021
@grlee77 grlee77 deleted the float32_measure_v2 branch July 8, 2021 20:40
@grlee77 grlee77 mentioned this pull request Sep 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfezzani rfezzani rfezzani left review comments

@jni jni jni approved these changes

Assignees
No one assigned
Labels
⏩ type: Enhancement Improve existing features 📜 type: API Involves API change(s)
Projects
skimage2 API
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Most skimage.measure._moments module functions don't support float32 operations
3 participants
@grlee77 @jni @rfezzani