Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase cibuildwheel verbosity #5370

Merged
merged 2 commits into from
May 3, 2021
Merged

Conversation

leej3
Copy link
Contributor

@leej3 leej3 commented May 3, 2021

Description

Currently cibuildwheel is failing for cpython 3.8. I believe this is due to a failure to resolve a numpy version, deduced by the fact that the build fails when trying to import numpy. The source of the failed import is hard to infer from the CI log though because of the default verbosity of cibuildwheel: increasing this will likely make debugging easier in the future.

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.

Copy link
Member

@jni jni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with this, but I'll let @grlee77 and/or @hmaarrfk confirm in case there's reasons we wouldn't want this that I'm unaware of...

@hmaarrfk
Copy link
Member

hmaarrfk commented May 3, 2021

Should we use the global env variables to avoid repeating the same thing on all jobs?

@grlee77
Copy link
Contributor

grlee77 commented May 3, 2021

If I understand @hmaarrfk's suggestion properly, it is just to place once at the top (prior to the start of the jobs: section)?

env:
    CIBW_BUILD_VERBOSITY: 2

@hmaarrfk
Copy link
Member

hmaarrfk commented May 3, 2021

Yes, I believe that is correct.

@hmaarrfk
Copy link
Member

hmaarrfk commented May 3, 2021

env:
    CIBW_BUILD_VERBOSITY: 2
    CIBW_TEST_REQUIRES: pytest pooch pytest-localserver pytest-faulthandler
    CIBW_TEST_COMMAND: pytest --pyargs skimage

We might as well move a few other stuff up there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants