Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

single precision support in skimage.segmentation #5373

Merged
merged 8 commits into from May 4, 2021

Conversation

grlee77
Copy link
Contributor

@grlee77 grlee77 commented May 3, 2021

Description

This PR adds float32 support to most functions in skimage.segmentation.

random_walker and slic already had float32 support, but some additional tests were added.

I skipped felzenswalb and watershed for now as the Cython code for these was a little more involved, so those two still promote to double precision internally.

Checklist

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.

@grlee77 grlee77 added the ⏩ type: Enhancement Improve existing features label May 3, 2021
@pep8speaks
Copy link

pep8speaks commented May 3, 2021

Hello @grlee77! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-05-04 01:00:08 UTC

Copy link
Member

@rfezzani rfezzani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent @grlee77, I just left a code formatting suggestion 😉. Thank you!

skimage/segmentation/active_contour_model.py Outdated Show resolved Hide resolved
skimage/segmentation/active_contour_model.py Outdated Show resolved Hide resolved
Co-authored-by: Riadh Fezzani <rfezzani@gmail.com>
Copy link
Member

@mkcor mkcor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for all the cleanup as well!

@mkcor mkcor merged commit 481ea16 into scikit-image:main May 4, 2021
@grlee77 grlee77 deleted the float32_segmentation branch July 8, 2021 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⏩ type: Enhancement Improve existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants