Speed up find_local_max when given a finite num_peaks #5394
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Optimizes _shared.coord.ensure_spacing as used in
feature.peak.find_local_max when given num_peaks
There's no need to process all candidates, which could
far outnumber the requested maximum, since candidates
in find_local_max are sorted by intensity. So only return
the first few matches and ignore the rest.
The resulting speedup can be huge in a number of cases
For reviewers
later.
__init__.py
.doc/release/release_dev.rst
.