Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

residual multichannel->channel_axis fixes #5427

Merged
merged 3 commits into from
Jun 21, 2021

Conversation

grlee77
Copy link
Contributor

@grlee77 grlee77 commented Jun 11, 2021

Description

The first commit here cleans up a few residual uses of multichannel in docstring examples, parameter descriptions and warning texts.

The second commit is to update the benchmark scripts with a _channel_kwarg helper that will specify multichannel when benchmarking against skimage<0.19, but channel_axis on newer versions.

Checklist

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.

This commit will allow benchmarks to run across versions pre/post multichannel->channel_axis transition
@grlee77 grlee77 added the 🔧 type: Maintenance Refactoring and maintenance of internals label Jun 11, 2021
@grlee77 grlee77 added this to the 0.19 milestone Jun 11, 2021
Copy link
Member

@mkcor mkcor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! Thank you, @grlee77 🙏

skimage/transform/_warps.py Outdated Show resolved Hide resolved
skimage/transform/_warps.py Outdated Show resolved Hide resolved
Co-authored-by: Marianne Corvellec <marianne.corvellec@ens-lyon.org>
@rfezzani rfezzani merged commit dad624b into scikit-image:main Jun 21, 2021
@rfezzani
Copy link
Member

🎉 Thank you @grlee77 for your hard work and @mkcor for the reminder 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔧 type: Maintenance Refactoring and maintenance of internals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants