Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix numpy deprecation in an example #5429

Merged
merged 3 commits into from
Jun 17, 2021
Merged

Conversation

sciunto
Copy link
Member

@sciunto sciunto commented Jun 16, 2021

Description

See https://scikit-image.org/docs/dev/auto_examples/color_exposure/plot_local_equalize.html#sphx-glr-auto-examples-color-exposure-plot-local-equalize-py

Checklist

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.

Copy link
Contributor

@grlee77 grlee77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@grlee77
Copy link
Contributor

grlee77 commented Jun 17, 2021

There are quite a few CI errors, but they look unrelated. It is a warning related to registration for colormaps within seaborn.

/opt/hostedtoolcache/Python/3.8.10/x64/lib/python3.8/site-packages/seaborn/cm.py:1582: UserWarning:

Trying to register the cmap 'rocket' which already exists.

/opt/hostedtoolcache/Python/3.8.10/x64/lib/python3.8/site-packages/seaborn/cm.py:1583: UserWarning:

Trying to register the cmap 'rocket_r' which already exists.

/opt/hostedtoolcache/Python/3.8.10/x64/lib/python3.8/site-packages/seaborn/cm.py:1582: UserWarning:

Trying to register the cmap 'mako' which already exists.

/opt/hostedtoolcache/Python/3.8.10/x64/lib/python3.8/site-packages/seaborn/cm.py:1583: UserWarning:

Trying to register the cmap 'mako_r' which already exists.

/opt/hostedtoolcache/Python/3.8.10/x64/lib/python3.8/site-packages/seaborn/cm.py:1582: UserWarning:

Trying to register the cmap 'icefire' which already exists.

/opt/hostedtoolcache/Python/3.8.10/x64/lib/python3.8/site-packages/seaborn/cm.py:1583: UserWarning:

Trying to register the cmap 'icefire_r' which already exists.

/opt/hostedtoolcache/Python/3.8.10/x64/lib/python3.8/site-packages/seaborn/cm.py:1582: UserWarning:

Trying to register the cmap 'vlag' which already exists.

/opt/hostedtoolcache/Python/3.8.10/x64/lib/python3.8/site-packages/seaborn/cm.py:1583: UserWarning:

Trying to register the cmap 'vlag_r' which already exists.

/opt/hostedtoolcache/Python/3.8.10/x64/lib/python3.8/site-packages/seaborn/cm.py:1582: UserWarning:

Trying to register the cmap 'flare' which already exists.

/opt/hostedtoolcache/Python/3.8.10/x64/lib/python3.8/site-packages/seaborn/cm.py:1583: UserWarning:

Trying to register the cmap 'flare_r' which already exists.

/opt/hostedtoolcache/Python/3.8.10/x64/lib/python3.8/site-packages/seaborn/cm.py:1582: UserWarning:

Trying to register the cmap 'crest' which already exists.

/opt/hostedtoolcache/Python/3.8.10/x64/lib/python3.8/site-packages/seaborn/cm.py:1583: UserWarning:

Trying to register the cmap 'crest_r' which already exists.

@grlee77 grlee77 merged commit a1c5846 into scikit-image:main Jun 17, 2021
@grlee77
Copy link
Contributor

grlee77 commented Jun 17, 2021

actually, I am not sure the above warnings are the cause of the failure. It looks like it may have been:

Warning, treated as error:
/home/runner/work/scikit-image/scikit-image/skimage/viewer/viewers/core.py:docstring of skimage.viewer.viewers.core.CollectionViewer:1:duplicate object description of skimage.viewer.viewers.core.CollectionViewer, other instance in api/skimage.viewer, use :noindex: for one of them

but that is also unrelated to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants