Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename label variable to circumvent link issue in docs. #5433

Merged
merged 2 commits into from
Jun 20, 2021

Conversation

mkcor
Copy link
Member

@mkcor mkcor commented Jun 18, 2021

Description

Fixes #5414 -- thanks for catching this, @jni

Another way of avoiding this issue is to import submodules rather than functions; the link is correct when calling measure.label. Personally, I prefer writing

from skimage import draw, measure, transform

in gallery examples, so functions are prefixed with their submodule and the reader becomes familiar with the code structure...

Checklist

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.

@pep8speaks
Copy link

Hello @mkcor! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 86:1: E402 module level import not at top of file

@mkcor mkcor added the 📄 type: Documentation Updates, fixes and additions to documentation label Jun 18, 2021
@grlee77
Copy link
Contributor

grlee77 commented Jun 20, 2021

This looks good. The failures seen here are unrelated and resolved by #5433

@grlee77 grlee77 merged commit d6957d4 into scikit-image:main Jun 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📄 type: Documentation Updates, fixes and additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect link for label in regionprops gallery example
3 participants