support single precision in skimage.color #5443
Merged
+160
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make sure np.float16 gets promoted to np.float32
These functions seem sensitive to floating point error, so use higher precision
it seems only get_DH2 needs to be in double precision for accuracy
remove reliance on unittest.TestCase in test_colorconv.py
grlee77
added
⏩ type: Enhancement
mkcor
approved these changes
Jul 16, 2021
Co-authored-by: Marianne Corvellec <marianne.corvellec@ens-lyon.org>
|
Thank you @grlee77, merging 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR preserves float32 dtype in the color conversion functions (I had forgotten this one when I opened all of the other single-precision PRs awhile back).
I did find that I had to keep internal computations in the
get_DH2helper in double precision to pass the existingtest_delta_e.pytests, though.The output remains
np.float64as it was prior to this PR for all integer-type inputs.Checklist
./doc/examples(new features only)./benchmarks, if your changes aren't covered by anexisting benchmark
For reviewers
later.
__init__.py.doc/release/release_dev.rst.