Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standardize on num_iter and max_num_iter keyword names #5444

Merged
merged 11 commits into from
Jul 8, 2021

Conversation

grlee77
Copy link
Contributor

@grlee77 grlee77 commented Jun 26, 2021

Description

This PR addresses one of the cases discussed in #4154.

There is no change in behavior aside from the deprecation warnings when an old parameter name is provided. These warnings are explicitly tested via expected_warnings

Checklist

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.

@grlee77 grlee77 added 🔧 type: Maintenance Refactoring and maintenance of internals 📜 type: API Involves API change(s) labels Jun 26, 2021
@pep8speaks
Copy link

pep8speaks commented Jun 26, 2021

Hello @grlee77! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-06-26 21:58:57 UTC

Copy link
Member

@rfezzani rfezzani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Thank you again @grlee77 😉

@rfezzani rfezzani merged commit 39914ec into scikit-image:main Jul 8, 2021
@grlee77 grlee77 deleted the api-iterations-parameters branch July 8, 2021 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📜 type: API Involves API change(s) 🔧 type: Maintenance Refactoring and maintenance of internals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants