Do not mark image edges in 'subpixel' mode of find_boundaries #5447
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR closes #5432, following the suggestion by @firerain42. If there is some reason we want to keep the option with the old behavior of treating the boundary of the image as an edge, let me know. At the moment I am considering this a bug fix and so have not set up a deprecation cycle.
It seems none of the other
mode
options tofind_boundary
mark the edge as a boundary, it was only the subpixel mode. A test was added that demonstrates this for all modes.@firerain42, if you are interested in being credited as a co-author on the commit message, please provide a name and email address and I will add a comment for that
Checklist
./doc/examples
(new features only)./benchmarks
, if your changes aren't covered by anexisting benchmark
For reviewers
later.
__init__.py
.doc/release/release_dev.rst
.