Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not mark image edges in 'subpixel' mode of find_boundaries #5447

Merged
merged 2 commits into from
Jun 28, 2021

Conversation

grlee77
Copy link
Contributor

@grlee77 grlee77 commented Jun 28, 2021

Description

This PR closes #5432, following the suggestion by @firerain42. If there is some reason we want to keep the option with the old behavior of treating the boundary of the image as an edge, let me know. At the moment I am considering this a bug fix and so have not set up a deprecation cycle.

It seems none of the other mode options to find_boundary mark the edge as a boundary, it was only the subpixel mode. A test was added that demonstrates this for all modes.

@firerain42, if you are interested in being credited as a co-author on the commit message, please provide a name and email address and I will add a comment for that

Checklist

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.

TST: add test cases that no boundaries are found for constant-valued images
@grlee77 grlee77 added the 🩹 type: Bug fix Fixes unexpected or incorrect behavior label Jun 28, 2021
Copy link
Member

@rfezzani rfezzani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @grlee77, I'll wait for @firerain42 answer if he want to be sited as co-author before merging 😉

@firerain42
Copy link
Contributor

Thanks @grlee77 for implementing the fix and @jni and @rfezzani for the review.

If it's no hassle for you, I would like to be a co-author (Lukas Petrich firerain42@googlemail.com). Thanks.

@grlee77 grlee77 merged commit 44ff414 into scikit-image:main Jun 28, 2021
@grlee77
Copy link
Contributor Author

grlee77 commented Jun 28, 2021

Thanks @firerain42, I added the text for co-authorship while creating the merge commit. You can see it here:
44ff414

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🩹 type: Bug fix Fixes unexpected or incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'subpixel' boundaries at the edges of an image
4 participants