Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix behavior of is_low_contrast for boolean inputs #5467

Merged
merged 9 commits into from
Jul 17, 2021
Merged

Fix behavior of is_low_contrast for boolean inputs #5467

merged 9 commits into from
Jul 17, 2021

Conversation

grlee77
Copy link
Contributor

@grlee77 grlee77 commented Jul 8, 2021

Description

This PR rreplaces #5247 which had been inactive for a few months. A simple test function was added.

Checklist

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.

@grlee77 grlee77 added the 🩹 type: Bug fix Fixes unexpected or incorrect behavior label Jul 8, 2021
@grlee77 grlee77 added this to the 0.19 milestone Jul 8, 2021
@pep8speaks
Copy link

pep8speaks commented Jul 8, 2021 •
edited

Hello @grlee77! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-07-15 04:04:27 UTC

@grlee77 grlee77 mentioned this pull request Jul 8, 2021
Closed
@grlee77 grlee77 mentioned this pull request Jul 13, 2021
Closed
mkcor
mkcor reviewed Jul 13, 2021
View reviewed changes
Copy link
Member

@mkcor mkcor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for rescuing #5467! I suggested adding the key part of the test 😉

skimage/exposure/exposure.py Outdated Show resolved Hide resolved
skimage/exposure/tests/test_exposure.py Outdated Show resolved Hide resolved
grlee77 and others added 3 commits July 15, 2021 00:02
@alexdesiqueira alexdesiqueira merged commit 7b0d37d into scikit-image:main Jul 17, 2021
@alexdesiqueira
Copy link
Member

Thank you @grlee77!

@mkcor mkcor mentioned this pull request Sep 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkcor mkcor mkcor approved these changes

Assignees
No one assigned
Labels
🩹 type: Bug fix Fixes unexpected or incorrect behavior
Projects
None yet
Milestone
0.19
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@grlee77 @pep8speaks @alexdesiqueira @mkcor