-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove legacy Travis-CI scripts and update contributor documentation accordingly #5486
Remove legacy Travis-CI scripts and update contributor documentation accordingly #5486
Conversation
The remaining section command and corresponding tools/header.py also appear to no longer be used, but I have left them in place for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @grlee77 , the change looks good!
On a tangent, could you, please, point me to the PR[s] where GitHub Workflow is introduced? Seems that I have missed lots of changes to the CI...
Emma ported the tests to GitHub Actions in late 2020 when TravisCI started restricting credits to a level that it became no longer feasible as a free option for our CI: #5074 Juan got the wheel building set up using Documentation artifacts visible from PRs (via CircleCI): #4881 Two other very recent CI changes funded by the CZI grant are: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I seized the opportunity to improve the writing a little bit (but I broke the 79 char limit in some suggestions).
@grlee77 are you okay with the minor edits I suggested? If so, I can take of including them and I'll merge right away. |
Yes, those all look good. Thanks! |
Description
There were quite a few Travis scripts and mentions of Travis in the contributor documentation. This PR removes these. If we ever need any of this again in the future we can just retrieve it from the history.
Checklist
./doc/examples
(new features only)./benchmarks
, if your changes aren't covered by anexisting benchmark
For reviewers
later.
__init__.py
.doc/release/release_dev.rst
.