Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy Travis-CI scripts and update contributor documentation accordingly #5486

Merged
merged 7 commits into from
Aug 3, 2021

Conversation

grlee77
Copy link
Contributor

@grlee77 grlee77 commented Jul 21, 2021

Description

There were quite a few Travis scripts and mentions of Travis in the contributor documentation. This PR removes these. If we ever need any of this again in the future we can just retrieve it from the history.

Checklist

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.

@grlee77 grlee77 added the 🔧 type: Maintenance Refactoring and maintenance of internals label Jul 21, 2021
Copy link
Member

@soupault soupault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @grlee77 , the change looks good!

On a tangent, could you, please, point me to the PR[s] where GitHub Workflow is introduced? Seems that I have missed lots of changes to the CI...

@grlee77
Copy link
Contributor Author

grlee77 commented Jul 25, 2021

On a tangent, could you, please, point me to the PR[s] where GitHub Workflow is introduced? Seems that I have missed lots of changes to the CI...

Emma ported the tests to GitHub Actions in late 2020 when TravisCI started restricting credits to a level that it became no longer feasible as a free option for our CI: #5074

Juan got the wheel building set up using cibuildwheel around the same time: #5080

Documentation artifacts visible from PRs (via CircleCI): #4881

Two other very recent CI changes funded by the CZI grant are:
1.) option to run benchmarks by adding a run-benchmarks label to an open PR: #5424
2.) automated wheel building on GHA: #5397

Copy link
Member

@mkcor mkcor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I seized the opportunity to improve the writing a little bit (but I broke the 79 char limit in some suggestions).

CONTRIBUTING.txt Outdated Show resolved Hide resolved
CONTRIBUTING.txt Outdated Show resolved Hide resolved
CONTRIBUTING.txt Outdated Show resolved Hide resolved
CONTRIBUTING.txt Outdated Show resolved Hide resolved
@mkcor
Copy link
Member

mkcor commented Aug 3, 2021

@grlee77 are you okay with the minor edits I suggested? If so, I can take of including them and I'll merge right away.

@grlee77
Copy link
Contributor Author

grlee77 commented Aug 3, 2021

Yes, those all look good. Thanks!

@mkcor mkcor merged commit 5403c86 into scikit-image:main Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔧 type: Maintenance Refactoring and maintenance of internals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants