Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wheels for macOS 10.13 #5521

Merged
merged 1 commit into from
Sep 1, 2021
Merged

Conversation

grlee77
Copy link
Contributor

@grlee77 grlee77 commented Aug 19, 2021

Description

closes #5465 (fixes wheels for older OS X releases)

The first commit here is from Mark's comment: #5465 (comment)

An open question that Mark raised is why we only include libomp for the Python 3.9 case on macOS? Was this intentional or an oversight?

Checklist

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.

This fix was adapted by @hmaarrfk from scikit-learn/scikit-learn#19064

Co-authored-by: Mark Harfouche <mark.harfouche@gmail.com>
@grlee77 grlee77 added the 🤖 type: Infrastructure CI, packaging, tools and automation label Aug 19, 2021
@grlee77 grlee77 requested a review from hmaarrfk August 19, 2021 14:50
@grlee77 grlee77 added this to the 0.19 milestone Aug 19, 2021
@grlee77
Copy link
Contributor Author

grlee77 commented Aug 19, 2021

For reference, OS X 10.13 was released in September 2017:
https://en.wikipedia.org/wiki/MacOS_version_history#Releases

@grlee77
Copy link
Contributor Author

grlee77 commented Aug 19, 2021

Is 10.13 still the oldest OS X we want to support? (The table linked in the prior comment seems to indicate that 10.14 is the oldest that is still actively maintained by Apple)

@alexdesiqueira
Copy link
Member

Is 10.13 still the oldest OS X we want to support?

@grlee77 I'm not sure about MacOS stuff, but I don't think that keeping a version would hurt... 🙂

@alexdesiqueira
Copy link
Member

Thank you @grlee77 and @hmaarrfk! LGTM; feel free to keep it as 10.13, or to update to 10.14 if you'd prefer.

@hmaarrfk
Copy link
Member

hmaarrfk commented Sep 1, 2021

Lets keep it for this PR. Thanks!

@hmaarrfk hmaarrfk merged commit c1a284c into scikit-image:main Sep 1, 2021
@grlee77
Copy link
Contributor Author

grlee77 commented Sep 1, 2021

Just noticed that I left "scikit-learn" in a comment, but can fix that in a followup. Trying to look into whether we need this same brew install for the other Python versions as well... (the fix here was only for the Python 3.9 job!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 type: Infrastructure CI, packaging, tools and automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scikit-image 0.18.2 fails on OS X 10.13.6
3 participants