-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the user guide to use channel_axis rather than multichannel #5556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DOC: fix typo in visualization.rst
update wording of section describing BGR to RGB conversion Better describe the current dtype and scaling behavior of img_as_float
use | to get extra space, emulating a table footnote in RST
grlee77
added
the
📄 type: Documentation
Updates, fixes and additions to documentation
label
Sep 2, 2021
mkcor
reviewed
Sep 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this!
Co-authored-by: Marianne Corvellec <marianne.corvellec@ens-lyon.org>
mkcor
reviewed
Sep 3, 2021
Co-authored-by: Marianne Corvellec <marianne.corvellec@ens-lyon.org>
Updated. Thanks for the helpful suggestions, @mkcor. |
The It looks like upstream has already fixed it in: pypa/setuptools_scm#628 |
mkcor
approved these changes
Sep 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #5554
Updates the user guide to better describe the more flexible channel support via
channel_axis
. Also, avoids use of the deprecatedmultichannel
argument in examples.The description of
img_as_float
was also updated slightly to indicate its current behavior (no longer automatically rescales floating point inputs and preserves floating point precision).Checklist
./doc/examples
(new features only)./benchmarks
, if your changes aren't covered by anexisting benchmark
For reviewers
later.
__init__.py
.doc/release/release_dev.rst
.