Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docstring for dilation, which is now nD. #5978

Merged
merged 2 commits into from
Oct 22, 2021

Conversation

mkcor
Copy link
Member

@mkcor mkcor commented Oct 21, 2021

Description

Follows from #5262 (comment).

I'm not sure x is a great (conventional?) notation for a pixel's coordinates (no matter how many the dimensions are)... @grlee77 thoughts?

Checklist

  • Docstrings for all functions
  • Gallery example in ./doc/examples (new features only)
  • Benchmark in ./benchmarks, if your changes aren't covered by an
    existing benchmark
  • Unit tests
  • Clean style in the spirit of PEP8
  • Descriptive commit messages (see below)

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.

@mkcor mkcor added the 📄 type: Documentation Updates, fixes and additions to documentation label Oct 21, 2021
skimage/morphology/gray.py Outdated Show resolved Hide resolved
Copy link
Member

@rfezzani rfezzani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mkcor 😉

@rfezzani rfezzani merged commit f0fcdc8 into scikit-image:main Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📄 type: Documentation Updates, fixes and additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants