Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pixel graphs example #5991

Merged
merged 4 commits into from
Oct 28, 2021
Merged

Update pixel graphs example #5991

merged 4 commits into from
Oct 28, 2021

Conversation

jni
Copy link
Member

@jni jni commented Oct 27, 2021

Description

Closes #5984.

I've:

  • set the last plot to be the gallery thumbnail
  • suppressed the mpl Text return outputs from set_title
  • updated the text of the intro

@pep8speaks
Copy link

pep8speaks commented Oct 27, 2021 •
edited

Hello @jni! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-10-28 06:57:31 UTC

@jni jni requested a review from mkcor October 27, 2021 00:43
@mkcor mkcor added the 📄 type: Documentation Updates, fixes and additions to documentation label Oct 27, 2021
mkcor
mkcor reviewed Oct 27, 2021
View reviewed changes
Copy link
Member

@mkcor mkcor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @jni! I love the new introduction. 😃

I'm not approving and merging right away, just in case someone around would know more about the semicolon issue... Will approve and merge by tomorrow anyway.

doc/examples/applications/plot_pixel_graphs.py Outdated Show resolved Hide resolved
mkcor
mkcor reviewed Oct 27, 2021
View reviewed changes
doc/examples/applications/plot_pixel_graphs.py Outdated Show resolved Hide resolved
doc/examples/applications/plot_pixel_graphs.py Outdated Show resolved Hide resolved
doc/examples/applications/plot_pixel_graphs.py Outdated Show resolved Hide resolved
@jni @rfezzani @mkcor
Assign returns to dummy vars instead of semicolon
af718bc 
Co-authored-by: Riadh Fezzani <rfezzani@gmail.com>
Co-authored-by: Marianne Corvellec <marianne.corvellec@ens-lyon.org>
@mkcor mkcor merged commit 39a94a0 into scikit-image:main Oct 28, 2021
@jni jni deleted the pixel-graph-thumbnail branch November 3, 2021 03:21
@grlee77 grlee77 mentioned this pull request Feb 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfezzani rfezzani rfezzani left review comments

@mkcor mkcor mkcor approved these changes

Assignees
No one assigned
Labels
📄 type: Documentation Updates, fixes and additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gallery example about pixel graphs and geodesic centers should use last plot as thumbnail.
4 participants
@jni @pep8speaks @mkcor @rfezzani