Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scipy requirement to 1.4.1 and use scipy.fft instead of scipy.fftpack #5999

Merged
merged 5 commits into from
Nov 9, 2021

Conversation

srvanrell
Copy link
Contributor

@srvanrell srvanrell commented Nov 2, 2021

Description

  • Update requirement of scipy as suggested in isssue EXAMPLES: Change use of scipy.fftpack to scipy.fft #5986.
  • Update examples importing fftpack to use fft instead
  • Remove _shared.fft workaround that loaded numpy.fft, scipy.fft or scipy.fftpack
  • Update imports were necessary to use scipy.fft module

Closes #5986

Checklist

  • Docstrings for all functions
  • Gallery example in ./doc/examples (new features only)
  • Benchmark in ./benchmarks, if your changes aren't covered by an
    existing benchmark
  • Unit tests
  • Clean style in the spirit of PEP8
  • Descriptive commit messages (see below)

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.

@pep8speaks
Copy link

pep8speaks commented Nov 3, 2021

Hello @srvanrell! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 135:1: E402 module level import not at top of file

Comment last updated at 2021-11-09 00:51:55 UTC

@srvanrell srvanrell changed the title WIP: Update scipy version requirement to 1.4.1 and import fftpack to fft WIP: Update scipy requirement to 1.4.1 and use scipy.fft instead of scipy.fftpack Nov 3, 2021
@grlee77
Copy link
Contributor

grlee77 commented Nov 4, 2021

Thanks. The test failures here seem to be unrelated (They appear to be an issue with a recent release of setuptools)

@srvanrell
Copy link
Contributor Author

@grlee77 The PR looks complete for me but you mentioned in #5986 that there were some calls to astype that are no longer needed. Let me know if there is something more to do or fix. Thank you for your patience with a newbie.

@grlee77
Copy link
Contributor

grlee77 commented Nov 4, 2021

@grlee77 The PR looks complete for me but you mentioned in #5986 that there were some calls to astype that are no longer needed. Let me know if there is something more to do or fix. Thank you for your patience with a newbie.

Yes, I will take a look at that now and push any changes here.

no longer needed now that we unconditionally use scipy.fft which supports float32
Copy link
Contributor

@grlee77 grlee77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @srvanrell, this looks good!

@srvanrell srvanrell changed the title WIP: Update scipy requirement to 1.4.1 and use scipy.fft instead of scipy.fftpack Update scipy requirement to 1.4.1 and use scipy.fft instead of scipy.fftpack Nov 4, 2021
@grlee77 grlee77 added this to the 0.19 milestone Nov 9, 2021
@hmaarrfk
Copy link
Member

hmaarrfk commented Nov 9, 2021

Thanks you two!

@hmaarrfk hmaarrfk merged commit 9fea28b into scikit-image:main Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EXAMPLES: Change use of scipy.fftpack to scipy.fft
4 participants