-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update scipy requirement to 1.4.1 and use scipy.fft instead of scipy.fftpack #5999
Update scipy requirement to 1.4.1 and use scipy.fft instead of scipy.fftpack #5999
Conversation
28b6b85
to
da8b29f
Compare
Hello @srvanrell! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2021-11-09 00:51:55 UTC |
Thanks. The test failures here seem to be unrelated (They appear to be an issue with a recent release of |
no longer needed now that we unconditionally use scipy.fft which supports float32
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @srvanrell, this looks good!
Thanks you two! |
Description
scipy.fftpack
toscipy.fft
#5986.Closes #5986
Checklist
./doc/examples
(new features only)./benchmarks
, if your changes aren't covered by anexisting benchmark
For reviewers
later.
__init__.py
.doc/release/release_dev.rst
.