Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed lines generating Requires metadata #6017

Conversation

BKaraargirov
Copy link
Contributor

Description

When you remove the requires and leave only install_requires only Requires-Dist is generated.
More info: #6001

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.

@BKaraargirov BKaraargirov marked this pull request as ready for review November 8, 2021 11:44
Copy link
Contributor

@grlee77 grlee77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell this looks okay. Would be good to get a second confirmation from another dev familiar with these fields.

@hmaarrfk
Copy link
Member

hmaarrfk commented Nov 9, 2021

It seems that scipy only uses the install_requires.

https://gitlab.freedesktop.org/mesa/drm/-/issues/72

Lets do this.

@hmaarrfk hmaarrfk merged commit fac558b into scikit-image:main Nov 9, 2021
@grlee77
Copy link
Contributor

grlee77 commented Nov 9, 2021

Thanks @BKaraargirov!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants