Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce memory required by test_masked_registration_3d_contiguous_mask #6019

Conversation

grlee77
Copy link
Contributor

@grlee77 grlee77 commented Nov 9, 2021

Description

Recently, I saw this test failure that looks like an out of memory error occurred:
https://dev.azure.com/scikit-image/scikit-image/_build/results?buildId=7008&view=logs&jobId=c266ee3e-f298-5c55-b78e-d135f25941c2&j=c266ee3e-f298-5c55-b78e-d135f25941c2&t=76d8336e-2ec7-54e7-5531-ad7a9096482b

I think it came up once previously as well. In this PR, I just reduce the data size by a factor of 4 in that test case to reduce the memory required.

Checklist

  • Docstrings for all functions
  • Gallery example in ./doc/examples (new features only)
  • Benchmark in ./benchmarks, if your changes aren't covered by an
    existing benchmark
  • Unit tests
  • Clean style in the spirit of PEP8
  • Descriptive commit messages (see below)

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.

…tiguous_mask

avoid out of memory error when running tests on CI
@grlee77 grlee77 added the 🔧 type: Maintenance Refactoring and maintenance of internals label Nov 9, 2021
@grlee77 grlee77 changed the title TST: reduce memory requirement to run test_masked_registration_3d_con… reduce memory required by test_masked_registration_3d_contiguous_mask Nov 9, 2021
@grlee77
Copy link
Contributor Author

grlee77 commented Nov 15, 2021

@grlee77
Copy link
Contributor Author

grlee77 commented Nov 16, 2021

@scikit-image/core. Is anyone available to review this small PR? I think it may fix the Python 3.7 failures on Azure seen in multiple recent PRs.

@alexdesiqueira
Copy link
Member

LGTM. Thank you @grlee77!

@alexdesiqueira alexdesiqueira merged commit ab5764f into scikit-image:main Nov 16, 2021
@alexdesiqueira alexdesiqueira changed the title reduce memory required by test_masked_registration_3d_contiguous_mask Reduce memory required by test_masked_registration_3d_contiguous_mask Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔧 type: Maintenance Refactoring and maintenance of internals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants