Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python 3.10 test runs on GitHub Actions and Appveyor #6027

Merged
merged 12 commits into from
Nov 12, 2021

Conversation

grlee77
Copy link
Contributor

@grlee77 grlee77 commented Nov 9, 2021

Description

Adding test cases for Python 3.10 on CI. NumPy, SciPy and PyWavelets should have Python 3.10 wheels now, so let's see how this goes.

Checklist

  • Docstrings for all functions
  • Gallery example in ./doc/examples (new features only)
  • Benchmark in ./benchmarks, if your changes aren't covered by an
    existing benchmark
  • Unit tests
  • Clean style in the spirit of PEP8
  • Descriptive commit messages (see below)

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.

@grlee77 grlee77 added the 🤖 type: Infrastructure CI, packaging, tools and automation label Nov 9, 2021
@grlee77 grlee77 changed the title Add python 3.10 test runs on GitHub Actions and Azure Add python 3.10 test runs on GitHub Actions and Appveyor Nov 9, 2021
@grlee77
Copy link
Contributor Author

grlee77 commented Nov 10, 2021

It looks like we need to remove the call to bdist_wininst here since that command was deprecated in Python 3.8 and removed in Python 3.10:

- python setup.py bdist_wheel bdist_wininst

I think we can just drop it from that line, but we should perhaps just change to pip wheel . instead to be a bit more modern?

@grlee77
Copy link
Contributor Author

grlee77 commented Nov 10, 2021

@rfezzani, the following error occurred in the stitching demo, but I don't think it usually happens. I have seen multiple other recent builds pass, but I think this has also occurred in at least one other recent PR:

https://github.com/scikit-image/scikit-image/runs/4158420675?check_suite_focus=true#step:6:1580

Warning, treated as error:
/Users/runner/work/scikit-image/scikit-image/doc/examples/registration/plot_stitching.py failed to execute correctly: Traceback (most recent call last):
  File "/Users/runner/work/scikit-image/scikit-image/doc/examples/registration/plot_stitching.py", line 113, in <module>
    for dst in matching_corners]
  File "/Users/runner/work/scikit-image/scikit-image/doc/examples/registration/plot_stitching.py", line 113, in <listcomp>
    for dst in matching_corners]
AttributeError: 'NoneType' object has no attribute 'params'

I thought maybe it was an issue of differing initializations, but it does look like random seeds are set.

@grlee77
Copy link
Contributor Author

grlee77 commented Nov 11, 2021

I think these will all pass now that we pinned sphinx. let me trigger CI again to be sure

@hmaarrfk
Copy link
Member

Sorry, can you try to rebase. I might have created conflicts with pyproject.toml

@grlee77
Copy link
Contributor Author

grlee77 commented Nov 11, 2021

Sorry, can you try to rebase. I might have created conflicts with pyproject.toml

no problem it is just the one line with Cython requirements. I will use the setting for that from the other PR. All linux CI passes now and Appveyor passed last time around, so I will go ahead and fix the conflict and merge here.

@grlee77
Copy link
Contributor Author

grlee77 commented Nov 11, 2021

I guess we still need an approval to merge. I think it should be fine to merge now, but I am fine if you want to wait until CI completes again.

@jni jni merged commit 487a366 into scikit-image:main Nov 12, 2021
@jni
Copy link
Member

jni commented Nov 12, 2021

Awwwweeeesome, thank you both!!! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 type: Infrastructure CI, packaging, tools and automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants