-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add python 3.10 test runs on GitHub Actions and Appveyor #6027
Conversation
NumPy does not currently have a wheel for this case
It looks like we need to remove the call to Line 46 in 9fea28b
I think we can just drop it from that line, but we should perhaps just change to |
@rfezzani, the following error occurred in the stitching demo, but I don't think it usually happens. I have seen multiple other recent builds pass, but I think this has also occurred in at least one other recent PR: https://github.com/scikit-image/scikit-image/runs/4158420675?check_suite_focus=true#step:6:1580
I thought maybe it was an issue of differing initializations, but it does look like random seeds are set. |
remove use of bdist_wininst which was deprecated in Python 3.8 and removed in 3.10
I think these will all pass now that we pinned sphinx. let me trigger CI again to be sure |
Sorry, can you try to rebase. I might have created conflicts with pyproject.toml |
no problem it is just the one line with Cython requirements. I will use the setting for that from the other PR. All linux CI passes now and Appveyor passed last time around, so I will go ahead and fix the conflict and merge here. |
I guess we still need an approval to merge. I think it should be fine to merge now, but I am fine if you want to wait until CI completes again. |
Awwwweeeesome, thank you both!!! 🎉 |
Description
Adding test cases for Python 3.10 on CI. NumPy, SciPy and PyWavelets should have Python 3.10 wheels now, so let's see how this goes.
Checklist
./doc/examples
(new features only)./benchmarks
, if your changes aren't covered by anexisting benchmark
For reviewers
later.
__init__.py
.doc/release/release_dev.rst
.