Relax a couple of equality tests causing i686 test failures on cibuildwheel #6031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aling test This case was failing with differences of <1e-15 when testing i686 linux wheels
…point inputs less strict observed ~7-8% mismatch wheen testing i686 wheels via cibuildwheel other architectures passed with 0% mismatch.
grlee77
added
🔧 type: Maintenance
hmaarrfk
approved these changes
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This relaxes two tests for exact equality based on the two failures detailed at #6021 (comment).
This SLIC superpixel scaling test that is modified here was introduced fairly recently in #5518. I am not sure it was reasonable to expect exactly identical SLIC segmentation for different floating point scaling due to possible differences in numerical error internally. This relaxes to just check that >90% of the pixels have an identical label. Does this seem okay or are there better ideas?
Checklist
./doc/examples(new features only)./benchmarks, if your changes aren't covered by anexisting benchmark
For reviewers
later.
__init__.py.doc/release/release_dev.rst.