Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add two datasets for use in upcoming scientific tutorials. #6087

Merged
merged 4 commits into from Dec 29, 2021

Conversation

mkcor
Copy link
Member

@mkcor mkcor commented Dec 3, 2021

Description

Checklist

  • Docstrings for all functions
  • Gallery example in ./doc/examples (new features only)
  • Benchmark in ./benchmarks, if your changes aren't covered by an
    existing benchmark
  • Unit tests
  • Clean style in the spirit of PEP8
  • Descriptive commit messages (see below)

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.

@pep8speaks
Copy link

pep8speaks commented Dec 3, 2021

Hello @mkcor! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 163:80: E501 line too long (101 > 79 characters)
Line 164:80: E501 line too long (98 > 79 characters)
Line 178:80: E501 line too long (107 > 79 characters)
Line 179:80: E501 line too long (109 > 79 characters)

Comment last updated at 2021-12-04 15:27:20 UTC

'text', 'retina', 'rocket', 'shepp_logan_phantom',
'skin', 'stereo_motorcycle', 'vortex']
'skin', 'nickel_solidification', 'stereo_motorcycle',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not too big of a deal, but it looks like these were mostly alphabetical previously? (although text was out of place).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, sorry, that's because I first named it 'solidification' 😅 ('lily' was also out of place). Reordering the entire list... (except for 'data_dir', 'download_all')

skimage/data/_fetchers.py Outdated Show resolved Hide resolved
@grlee77 grlee77 merged commit ce70774 into scikit-image:main Dec 29, 2021
@hmaarrfk
Copy link
Member

out of curiosity, how does this help scientific tutorials? Won't you need to cut a release in time?

@mkcor mkcor deleted the add-new-data branch December 30, 2021 12:53
@mkcor
Copy link
Member Author

mkcor commented Dec 30, 2021

@hmaarrfk the dataset with cell images is for use in #5262 (which I will update as soon as I'm in front of my PC, i.e., probably tomorrow).

@hmaarrfk
Copy link
Member

Ah, understood.

@grlee77
Copy link
Contributor

grlee77 commented Jan 27, 2022

@meeseeksdev backport to v0.19.x

meeseeksmachine pushed a commit to meeseeksmachine/scikit-image that referenced this pull request Jan 27, 2022
alexdesiqueira pushed a commit that referenced this pull request Jan 27, 2022
…torials. (#6215)

Co-authored-by: Gregory Lee <grlee77@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants