New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add two datasets for use in upcoming scientific tutorials. #6087
Conversation
Hello @mkcor! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2021-12-04 15:27:20 UTC |
skimage/data/__init__.py
Outdated
'text', 'retina', 'rocket', 'shepp_logan_phantom', | ||
'skin', 'stereo_motorcycle', 'vortex'] | ||
'skin', 'nickel_solidification', 'stereo_motorcycle', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not too big of a deal, but it looks like these were mostly alphabetical previously? (although text
was out of place).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, sorry, that's because I first named it 'solidification' 😅 ('lily' was also out of place). Reordering the entire list... (except for 'data_dir', 'download_all')
out of curiosity, how does this help scientific tutorials? Won't you need to cut a release in time? |
Ah, understood. |
@meeseeksdev backport to v0.19.x |
…cientific tutorials.
…torials. (#6215) Co-authored-by: Gregory Lee <grlee77@gmail.com>
Description
data.protein_transport()
shall be used in Add textbook-like tutorial on measuring fluorescence at nuclear envelope. #5262data.nickel_solidification()
shall be used in a tutorial in preparation with @cgusbChecklist
./doc/examples
(new features only)./benchmarks
, if your changes aren't covered by anexisting benchmark
For reviewers
later.
__init__.py
.doc/release/release_dev.rst
.