Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add release notes for v0.19.1 #6116

Merged
merged 8 commits into from
Dec 15, 2021

Conversation

grlee77
Copy link
Contributor

@grlee77 grlee77 commented Dec 9, 2021

Description

This is mostly fixes to wheels and some edge cases encountered in the tests on conda-forge, but we did resolve a couple unintentional backwards incompatibile changes.

Checklist

  • Docstrings for all functions
  • Gallery example in ./doc/examples (new features only)
  • Benchmark in ./benchmarks, if your changes aren't covered by an
    existing benchmark
  • Unit tests
  • Clean style in the spirit of PEP8
  • Descriptive commit messages (see below)

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.

@grlee77 grlee77 added the 📄 type: Documentation Updates, fixes and additions to documentation label Dec 9, 2021
@grlee77 grlee77 added this to the 0.19.1 milestone Dec 9, 2021
@psobolewskiPhD
Copy link
Contributor

Line 4: We're happy to announce the release of scikit-image v0.19.01
I think you mean v0.19.1?

Also, on macOS 12, M1 python 3.9 and 3.10 wheels from:
https://github.com/grlee77/scikit-image/actions/runs/1557165043
seem fine:
python 3.9.7:
=========== 7152 passed, 41 skipped, 31 warnings in 74.89s (0:01:14) ===========
https://gist.github.com/psobolewskiPhD/25907a88515315e0c5998da8f860fcee

python 3.10.0:
=========== 7152 passed, 41 skipped, 31 warnings in 79.53s (0:01:19) ===========
https://gist.github.com/psobolewskiPhD/26c65900d6062e73b249ff3f1d3a8c13

@grlee77
Copy link
Contributor Author

grlee77 commented Dec 9, 2021

Thanks @psobolewskiPhD. Most of those are expected warnings, but there are a couple that should be easy to resolve and should have already been raising an error on CI! (we have one test matrix entry that is supposed to raise an error on any unexpected warnings, but clearly that did not happen)

doc/release/release_0.19.rst Outdated Show resolved Hide resolved
doc/release/release_0.19.rst Outdated Show resolved Hide resolved
Co-authored-by: Marianne Corvellec <marianne.corvellec@ens-lyon.org>
Copy link
Member

@mkcor mkcor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to wait for #6118 to be merged and/or #6093 to be decided upon to release v0.19.1? If not, I'm happy to approve.

doc/release/release_0.19.rst Outdated Show resolved Hide resolved
@grlee77
Copy link
Contributor Author

grlee77 commented Dec 15, 2021

should be ready now. everything else tagged for 0.19.1 has been merged so once this is in I can kick off the release

doc/release/release_0.19.rst Outdated Show resolved Hide resolved
@grlee77 grlee77 merged commit b2e378d into scikit-image:v0.19.x Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📄 type: Documentation Updates, fixes and additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants